Fix concurrency issue in ServiceFactoryImpl#174
Open
markusheiden wants to merge 1 commit intoBingAds:mainfrom
Open
Fix concurrency issue in ServiceFactoryImpl#174markusheiden wants to merge 1 commit intoBingAds:mainfrom
markusheiden wants to merge 1 commit intoBingAds:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.microsoft.bingads.internal.ServiceFactoryImplcreates a newjakarta.xml.ws.Serviceusing a thread pool. Though it shuts down the thread pool immediately after the creation it does not wait for the shutdown to complete.To avoid any concurrency/visibility issues, this PR synchronizes the creation of the service instance.