Do not use broken suds.cache.ObjectCache#108
Open
khvn26 wants to merge 1 commit intoBingAds:masterfrom
Open
Conversation
Author
|
Any movement on this? |
|
This solution looks good to me! |
|
This is seriously affecting us in production right now. Would be great if we could default to not using a file-system cache, or any cache at all. |
Collaborator
|
yes I agree that we should not using cache at all - since v13.0.9.1, we are using local 'proxies' to cache wsdl. So there should be no benefit to have the cache. we will work on merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider fixing #4 since it seriously affects library usage in production.
This PR introduces a simple in-memory cache to use by default not only during
ServiceClientinstantiation, but also with the module-levelsuds.Clientinstance which provides the object factory for the library internals.Without the fix,
/tmp/sudswas becoming enormous pretty fast even when providing a custom cache insuds_optionssince_CAMPAIGN_MANAGEMENT_SERVICE_V12was still usingsuds.cache.ObjectCache.The fix does not change dependencies or monkey-patch anything.