Skip to content

fix: xml report iteration failure#301

Open
tommasobertoni wants to merge 1 commit intoBingAds:mainfrom
tommasobertoni:fix/xml-report-iteration-failure-300
Open

fix: xml report iteration failure#301
tommasobertoni wants to merge 1 commit intoBingAds:mainfrom
tommasobertoni:fix/xml-report-iteration-failure-300

Conversation

@tommasobertoni
Copy link
Copy Markdown

The context iterator is an ElementTree.IterParseIterator instance and does not expose a next() method.
The fix uses the __next__() method instead.

Additionally:

  • remove import codecs and import re as unused
  • define _XmlIterator for type hinting

Fixes #300.

@tommasobertoni
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Bending Spoons"

@tommasobertoni
Copy link
Copy Markdown
Author

Hi @xinyuwen2 👋🏻 are you able to take a look? 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iteration failure when downloading XML report

1 participant