Skip to content

Add subType for ImageAssets #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VadimSaratov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add subType for ImageAssets #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bingads/v13/internal/extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,7 @@ def field_to_csv_ImageAssetLinks(entity):
contract['pinnedField'] = assetLink.PinnedField if hasattr(assetLink, 'PinnedField') else None
contract['targetWidth'] = assetLink.TargetWidth if hasattr(assetLink, 'TargetWidth') else None
contract['targetHeight'] = assetLink.TargetHeight if hasattr(assetLink, 'TargetHeight') else None
contract['subType'] = assetLink.SubType if hasattr(assetLink, 'SubType') else None
assetLinkContracts.append(contract)
if len(assetLinkContracts) > 0:
return json.dumps(assetLinkContracts)
Expand All @@ -767,6 +768,7 @@ def csv_to_field_ImageAssetLinks(assetLinks, value):
asset_link = _CAMPAIGN_OBJECT_FACTORY_V13.create('AssetLink')
asset_link.Asset = _CAMPAIGN_OBJECT_FACTORY_V13.create('ImageAsset')
asset_link.Asset.Type = 'ImageAsset'
asset_link.Asset.SubType = assetLinkContract.get('subType')
asset_link.Asset.CropHeight = assetLinkContract.get('cropHeight')
asset_link.Asset.CropWidth = assetLinkContract.get('cropWidth')
asset_link.Asset.CropX = assetLinkContract.get('cropX')
Expand Down