Add Services FAQ page - #35
Draft
claude[bot] wants to merge 2 commits into
Draft
Conversation
The faq page publishes 13 questions (4 samples + 3 sequencing + 3 data + 3 pricing) and the FAQPage JSON-LD maps all of them; the spec asserted a stale count of 12, failing CI on every attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sean, Michelle · Slack thread
Before: the site had no FAQ page — just a small six-question inline FAQ block on
/services.After: a dedicated FAQ page at
/faqcarrying all 12 Q&As from issue #34 under its four headings, linked from the services page (the inline FAQ is now a teaser pointing at/faq) and from the footer.What: Adds the Services FAQ page drafted in #34, including Michelle's sequencing-technology Q&A verbatim, and reconciles the old inline services FAQ into a teaser.
How: New
src/pages/faq.astrobuilt from the existingBaseLayout/Eyebrow/PageNav/CtaBandcomponents with the same section styling as/services. TheFAQPageJSON-LD is now emitted by/faq(@id…/faq#faq, 12 questions) and removed from/services; the services page keeps its BioInfoOS and quote-builder asides in the teaser section. Footer gains a FAQ link,llms-full.txtpoints at the new route, and the e2e specs were updated to match (JSON-LD assertions moved to a newtests/e2e/faq.spec.ts).Closes #34
Summary
/faqwith the 12 drafted Q&As (4 groups), scroll-spy PageNav, andFAQPageJSON-LD/faq; add footer link; updatellms-full.txtScope
src/pages/*,src/data/*)src/components/*)src/styles/*)public/assets/images/*)public/llms.txt,src/pages/api/*.json.ts) —src/pages/llms-full.txt.tsastro.config.mjs,.github/,wrangler.toml)tests/**)docs/**,README.md)Verification
npm run check— 0 errorsnpm test— all pass (113/113)npm run test:e2e— not run in this sandbox (no Playwright browsers); specs updated to match the new structure, please run in CI@idmoved fromservices#faqtofaq#faq; please spot-checknpm run buildandnpm run lintalso pass (build'sRequest.cffetch warning is the known Cloudflare-adapter sandbox fallback, unrelated).Open questions for review
/contact?topic=sequencing. Michelle to decide the final wording/label.[confirm: preservation guidance per sample type]): kept generic — "requirements depend on sample type and assay; we'll cover them during scoping." Needs verification before adding specifics.[confirm: data ownership / confidentiality policy]): the unverified "Your project data belongs to you" claim is not published; the answer defers to scoping ("if your project has specific confidentiality or data-ownership needs, talk to us"). Needs the real policy wording./faqis canonical;/serviceskeeps only a teaser + link, and theFAQPageJSON-LD moved with the content to avoid duplicate structured data. The BioInfoOS / quote asides stayed on/services. Fine to revisit if you'd rather keep a few Q&As inline.Notes for reviewer
Route chosen:
/faq(flat, matching the site's flat page routing). Nav left unchanged (top level is intentionally tight); linking is via services teaser + footer.Generated by Claude Code