Repository navigation
test: make local test helpers importable in subprocesses - #202
Merged
Merged
Conversation
Birfy
marked this pull request as ready for review
October 9, 2026 23:46
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced problem
On unchanged main,
tests/was a namespace package. This host also has unrelated regulartestsandscriptspackages in Anaconda's Python 3.9 site-packages. The detached worker resolvestests.test_evolvespec:stub_reflectin a fresh process, where the installedtestspackage shadows the repository namespace.The existing
test_start_status_show_apply_flowthen ended at round 0 with:The repro used the local deterministic stub spec with
OPENAI_API_KEYandOPENAI_BASE_URLunset; it made no model/API calls.Fix
testsandscriptsexplicit packages so their local modules win over unrelated installed packages.tests/to pytest's configured import path to preserve existing top-level test helper imports.testsandscriptspackages.This is separate from PR #201 and changes no runtime package behavior.
Verification
cf19d2be37f2fd295efcb32e57a5d590b4b13961(main368f9a85d6da7f65d67ff82138c6348da8e78c8b).pytest --collect-only -qsucceeded locally; focused MCP, EvolveSpec, package-resolution and packaging tests: 56 passed, 2 skipped across the recorded runs, with provider credentials unset.7ab7cca35b64a04e259be823f3b1228831dafa35: tests, wheel build and wheel smoke on Python 3.9, 3.10, 3.11 and 3.12; strict docs build passed. Docs deploy skipped for the PR as expected.scriptspackage address those; the corrected exact head is green.Independent review is clean; the PR is Ready for review.