Skip to content

frontend/backend: add message signing for BTC and ETH accounts #3913

Merged
benma merged 1 commit into
BitBoxSwiss:masterfrom
jstrnbrg:sign_msg
Apr 11, 2026
Merged

frontend/backend: add message signing for BTC and ETH accounts #3913
benma merged 1 commit into
BitBoxSwiss:masterfrom
jstrnbrg:sign_msg

Conversation

@jstrnbrg
Copy link
Copy Markdown
Collaborator

@jstrnbrg jstrnbrg commented Mar 4, 2026

Prerequisite: #3912

@jstrnbrg jstrnbrg changed the title frontend/backend: add message signing for BTC and ETH accounts WIP: frontend/backend: add message signing for BTC and ETH accounts Mar 4, 2026
@jstrnbrg jstrnbrg force-pushed the sign_msg branch 6 times, most recently from 84c3c59 to 8042601 Compare March 30, 2026 12:29
@jstrnbrg jstrnbrg changed the title WIP: frontend/backend: add message signing for BTC and ETH accounts frontend/backend: add message signing for BTC and ETH accounts Mar 30, 2026
@benma benma self-requested a review March 30, 2026 13:41
@jstrnbrg jstrnbrg force-pushed the sign_msg branch 2 times, most recently from 5589aff to c174d90 Compare March 31, 2026 12:39
@shonsirsha shonsirsha marked this pull request as draft April 2, 2026 05:14
@shonsirsha shonsirsha force-pushed the sign_msg branch 2 times, most recently from af19835 to 0b1ab26 Compare April 5, 2026 15:11
@shonsirsha shonsirsha marked this pull request as ready for review April 5, 2026 15:11
@shonsirsha shonsirsha marked this pull request as draft April 5, 2026 15:11
@shonsirsha
Copy link
Copy Markdown
Collaborator

shonsirsha commented Apr 5, 2026

Changes made

A. General refactoring
B. UI fixes:

  • Change arrows < > of addresses and its position w.r.t address count
  • Change “Sign message” icon under the accordion in used addresses list
  • Change message to “Message signed”
  • Unify border radius on copyable input
  • Change checkmark icon (success)
  • Change message input to be taller (success)
  • During sign message (confirm) stage, use blocking view instead of normal view.

cc @jstrnbrg

@shonsirsha shonsirsha assigned jstrnbrg and unassigned shonsirsha Apr 5, 2026
@shonsirsha shonsirsha force-pushed the sign_msg branch 3 times, most recently from 349a4de to cb00e5c Compare April 6, 2026 10:30
@jstrnbrg jstrnbrg marked this pull request as ready for review April 8, 2026 09:25
@benma benma assigned shonsirsha and unassigned jstrnbrg Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend LGTM

Co-Authored-By: jstrnbrg
Co-Authored-By: Marko Bencun <marko@shiftcrypto.ch>
@benma benma merged commit 55bb3d1 into BitBoxSwiss:master Apr 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants