Backend panic errors#4150
Merged
Merged
Conversation
benma
force-pushed
the
backend-panic-errors
branch
from
b9f9352 to
62c6b6f
Compare
bznein
approved these changes
May 28, 2026
Collaborator
bznein
left a comment
bznein
left a comment
There was a problem hiding this comment.
LGTM with just a couple of nits
Comment on lines
+404
to
407
| if err := headers.reorg(db, tip); err != nil { | ||
| return err | ||
| } | ||
| return nil |
Collaborator
There was a problem hiding this comment.
could aldo just be return headers.reorg(db,tip) but either is fine
| return headerTimestamp | ||
| } | ||
|
|
||
| func (transactions *Transactions) processTxForAddress( |
Collaborator
There was a problem hiding this comment.
maybe add a comment to explain the returned value? It's a bit confusing for a function named processX to also return a mysterious boolean
| return input != nil, nil | ||
| } | ||
|
|
||
| func (transactions *Transactions) removeTxForAddress( |
Collaborator
There was a problem hiding this comment.
Maybe also here a comment explaining the returned bool?
Transaction history updates used to publish notifier events and start transaction verification while the database update transaction was still open. If a later DB operation failed and rolled back, the app could notify listeners or verify transactions that were never committed. Collect the notifier and verification work during the DB update and run it only after DBUpdate returns successfully.
benma
force-pushed
the
backend-panic-errors
branch
from
62c6b6f to
dcd56e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before asking for reviews, here is a check list of the most common things you might need to consider: