frontend: allow entering fiat in lightning receive#4163
Conversation
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThe Receive Lightning route component was refactored to improve amount validation and conversion. The component now uses an explicit ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontends/web/src/routes/lightning/receive/receive.tsx`:
- Around line 236-244: The fiat input uses a SAT-specific translation key
causing incorrect placeholder text: update the NumberInput with id
"amountFiatInput" to use a dedicated fiat/generic key (e.g. replace
t('lightning.receive.amountSats.placeholder') with a new key like
'lightning.receive.amountFiat.placeholder' or
'lightning.receive.amount.placeholder') and add that new key and translations to
the locale files for all supported languages so the NumberInput (component:
NumberInput, prop: placeholder) shows the correct fiat/generic placeholder.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3e3d0ce1-a432-4ef2-979c-3560bce17ced
📒 Files selected for processing (1)
frontends/web/src/routes/lightning/receive/receive.tsx
Before asking for reviews, here is a check list of the most common things you might need to consider: