Skip to content

fix: fix the problem with empty objects in intersections - #1059

Merged
shenbenson merged 2 commits into
masterfrom
dx-2181-fix-empty-object
Oct 27, 2025
Merged

fix: fix the problem with empty objects in intersections#1059
shenbenson merged 2 commits into
masterfrom
dx-2181-fix-empty-object

Conversation

@shenbenson

@shenbenson shenbenson commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This fixes the problem with empty objects like:

      requestBody:
        content:
          application/json:
            schema:
              allOf:
                - type: object
                  properties: {}
                - $ref: '#/components/schemas/ESignatures'

Objects like these causes ReadMe to not render the endpoint properly.

Manually tested locally in entity-validation, and it addresses the problem while not affecting other parts of the file:

image

Ticket: DX-2181

@shenbenson
shenbenson marked this pull request as ready for review October 27, 2025 16:07
@shenbenson
shenbenson requested a review from a team as a code owner October 27, 2025 16:07
@shenbenson
shenbenson enabled auto-merge October 27, 2025 18:02
starfy84
starfy84 approved these changes Oct 27, 2025
View reviewed changes

@starfy84 starfy84 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenbenson
shenbenson merged commit 29ebad7 into master Oct 27, 2025
6 checks passed
@shenbenson
shenbenson deleted the dx-2181-fix-empty-object branch October 27, 2025 19:14
@github-actions

github-actions Bot commented Oct 27, 2025

Copy link
Copy Markdown

🎉 This PR is included in version @api-ts/openapi-generator@5.10.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starfy84 starfy84 starfy84 approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shenbenson @starfy84