Repository navigation
🔖 release v0.5.3 - #36
Merged
Merged
Conversation
* 🐛 support Hyprland Lua dispatch for preview window control Hyprland 0.56 (shipped with Omarchy 4) evaluates `hyprctl dispatch` arguments as Lua, so the legacy `setfloating address:0x...` form fails to parse with exit 7. Every window dispatch ChalKak issues — float, pin, setprop, resizewindowpixel, movewindowpixel — silently failed, leaving the preview window tiled, unpinned and without its restored geometry. Render each dispatch in both dialects, try legacy first (a Lua-mode hyprctl rejects it with a non-zero exit, while older hyprctl can accept an unknown dispatcher with exit 0), and cache whichever dialect the compositor accepted. Boolean props are sent as "on"/"off" in the Lua dialect too, because hl.window.set_prop rejects a Lua boolean with "'value' is required". Pin retries now log at debug instead of emitting one warning per attempt. Claude-Session: https://claude.ai/code/session_01B7PA6MLMsm99vB2bZcfzJw * ⬆️ bump ocr-rs to the GCC 16 MNN build fix MNN adds -D__STRICT_ANSI__ on Linux and libstdc++ 16 then specializes numeric_limits<__int128> twice, so `cargo build` failed on GCC 16 with "redefinition of 'struct std::numeric_limits<__int128>'". Picks up BitYoungjae/rust-paddle-ocr#1, which probes the toolchain and passes -U__GLIBCXX_TYPE_INT_N_0 to the MNN cmake build only when it is affected. Claude-Session: https://claude.ai/code/session_01B7PA6MLMsm99vB2bZcfzJw
Patch release: restores floating/pinned preview windows on Hyprland 0.56 (Omarchy 4) and unblocks builds on GCC 16 toolchains. Claude-Session: https://claude.ai/code/session_01B7PA6MLMsm99vB2bZcfzJw
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developtomainfor the v0.5.3 patch release.Changes
src/app/hypr.rs— dual-dialecthyprctl dispatchsupport so preview/editor windows float and pin again on Hyprland 0.56 (Omarchy 4)Cargo.toml/Cargo.lock— version0.5.3,ocr-rsbumped to the GCC 16 MNN build fixIncluded PRs: #34, #35 (and #17, merged after the v0.5.2 tag).
Test Plan
cargo checkcargo test— 233 unit testscargo fmt --checkfloating=True pinned=Truewith restored geometry on Hyprland 0.56.2 / Omarchy 4.0.0Known non-blocking red checks, both pre-existing on
mainand unrelated to these changes:cargo-audit— advisory warnings in transitive deps (imageproc,randunsound;core2yanked), failing on scheduled runs since July.lint(continue-on-error: true) — clippy 1.97 flagscollapsible_matchinsrc/editor/tools/mod.rs, untouched by this release.https://claude.ai/code/session_01B7PA6MLMsm99vB2bZcfzJw