feat: comprehensive audit fixes, new tests, and production improvements#12
Merged
Merged
Conversation
Code Quality Fixes: - Fix Clippy errors: needless borrows, unused imports, clone on Copy types - Add #![allow(unpredictable_function_pointer_comparisons)] for UniFFI macro - Remove unused INTERNAL_EPOCH constant from mobile_manager - Add cargo::rustc-check-cfg for loom in build.rs - Replace vec![] with array literals, fix redundant closures Security & Documentation: - Expand THREAT_MODEL.md with FFI boundary security section - Add mobile-specific threat considerations - Document FFI trust model and error handling Test Improvements: - Add tests/replay_protection.rs - replay attack prevention tests - Add tests/server_policy.rs - server policy configuration tests - Add tests/xx_pattern.rs - XX pattern handshake tests - Add tests/network_partition.rs - network partition handling tests - Enhance loom_tests.rs with stress and race condition tests - Fix fuzz targets to use 3-step handshake API - Add missing dependencies to fuzz/Cargo.toml (sha2, zeroize) Session Manager: - Improve error messages with .expect() for mutex locks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive improvements from security audit addressing code quality, testing gaps, and documentation.
Code Quality Fixes
#![allow(unpredictable_function_pointer_comparisons)]for UniFFI macroINTERNAL_EPOCHconstant from mobile_managercargo::rustc-check-cfgfor loom in build.rsvec![]with array literals, fix redundant closuresSecurity & Documentation
New Test Files
tests/replay_protection.rs- replay attack prevention teststests/server_policy.rs- server policy configuration teststests/xx_pattern.rs- XX pattern handshake teststests/network_partition.rs- network partition handling testsTest Improvements
Session Manager
.expect()for mutex locksTest plan