Hotfix a few things on 0.5.0#768
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This hotfix release (0.5.0-1) addresses four critical bugs related to company signatory management, file handling, and identity chain serialization. The changes fix security issues with file encryption keys, improve validation logic for signatory removal, correct plaintext data type mismatches in identity blockchain operations, and ensure proper active identity switching when users are removed from companies.
- Fix company file operations to use company keys instead of personal identity keys for encryption/decryption
- Fix validation logic to only count fully accepted signatories when preventing removal of the last signatory
- Fix plaintext identity chain bug where accept/reject invite operations were incorrectly using the wrong data types
- Implement automatic switching to personal identity when a user is removed from a company they're currently using as active identity
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Bump version to 0.5.0-1 for hotfix release |
CHANGELOG.md |
Document the four bug fixes in hotfix release notes |
crates/bcr-ebill-wasm/src/api/company.rs |
Fix file retrieval to use company keys instead of personal keys |
crates/bcr-ebill-wasm/main.js |
Add test utility for fetching company proof files with proper key usage |
crates/bcr-ebill-wasm/index.html |
Add UI button for testing company file retrieval |
crates/bcr-ebill-core/src/protocol/blockchain/identity/mod.rs |
Fix plaintext data types for accept/reject signatory invite operations |
crates/bcr-ebill-core/src/protocol/blockchain/mod.rs |
Refactor iterator method from filter+next_back to rfind for cleaner code |
crates/bcr-ebill-api/src/service/company_service.rs |
Fix signatory validation, company file key usage, active identity switching, and add test mock |
crates/bcr-ebill-api/src/service/transport_service/mod.rs |
Remove unused import |
crates/bcr-ebill-transport/src/handler/company_chain_event_processor.rs |
Add active identity switching when remotely removed from company |
mtbitcr
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Relates to #766
✅ Checklist
Please ensure the following tasks are completed before requesting a review:
cargo fmt.cargo clippy.🚀 Changes Made
See above.
💡 How to Test
Please provide clear instructions on how reviewers can test your changes:
🤝 Related Issues
List any related issues, pull requests, or discussions:
📋 Review Guidelines
Please focus on the following while reviewing: