Skip to content

Fix keyset call#903

Merged
zupzup merged 1 commit into
masterfrom
fix-keyset-call
Apr 22, 2026
Merged

Fix keyset call#903
zupzup merged 1 commit into
masterfrom
fix-keyset-call

Conversation

@zupzup
Copy link
Copy Markdown
Collaborator

@zupzup zupzup commented Apr 22, 2026

  • Use mint client for get_keyset_info to have the right URL
  • Update bcr-common

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes mint keyset retrieval by routing get_keyset_info through the bcr-common mint client (to ensure the correct endpoint/base URL is used) and updates the bcr-common dependency revision accordingly.

Changes:

  • Refactor MintClient::get_keyset_info to parse the keyset id and call the mint client’s keyset endpoint instead of constructing a manual URL + raw reqwest call.
  • Bump bcr-common git revision to a newer commit.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/bcr-ebill-api/src/external/mint.rs Updates keyset lookup implementation to use the mint client API and parses keyset IDs into the correct type.
Cargo.toml Updates the bcr-common git rev to the version that supports/fixes the intended mint client behavior.

Comment thread crates/bcr-ebill-api/src/external/mint.rs Outdated
Comment thread crates/bcr-ebill-api/src/external/mint.rs
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.52%. Comparing base (0cc19e8) to head (4fe9553).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/bcr-ebill-api/src/external/mint.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   70.49%   70.52%   +0.03%     
==========================================
  Files         139      139              
  Lines       27689    27685       -4     
==========================================
+ Hits        19519    19526       +7     
+ Misses       8170     8159      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zupzup zupzup merged commit a31da52 into master Apr 22, 2026
9 of 10 checks passed
@zupzup zupzup deleted the fix-keyset-call branch April 22, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants