Fix keyset call#903
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes mint keyset retrieval by routing get_keyset_info through the bcr-common mint client (to ensure the correct endpoint/base URL is used) and updates the bcr-common dependency revision accordingly.
Changes:
- Refactor
MintClient::get_keyset_infoto parse the keyset id and call the mint client’s keyset endpoint instead of constructing a manual URL + rawreqwestcall. - Bump
bcr-commongit revision to a newer commit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/bcr-ebill-api/src/external/mint.rs |
Updates keyset lookup implementation to use the mint client API and parses keyset IDs into the correct type. |
Cargo.toml |
Updates the bcr-common git rev to the version that supports/fixes the intended mint client behavior. |
mtbitcr
approved these changes
Apr 22, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 70.49% 70.52% +0.03%
==========================================
Files 139 139
Lines 27689 27685 -4
==========================================
+ Hits 19519 19526 +7
+ Misses 8170 8159 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanbitcr
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_keyset_infoto have the right URL