Skip to content

Restore contact invites on recover#905

Merged
tompro merged 1 commit into
masterfrom
account-recovery-contacts
Apr 23, 2026
Merged

Restore contact invites on recover#905
tompro merged 1 commit into
masterfrom
account-recovery-contacts

Conversation

@tompro
Copy link
Copy Markdown
Collaborator

@tompro tompro commented Apr 23, 2026

📝 Description

Adds contact share handler to recovery processor. This will add all previously shared contacts into pending contact shares again and allow the user to add them later from the list. We need to keep them pending as we do not know which ones where already accepted (or rejected) before the restore.

Relates to: #699


✅ Checklist

Please ensure the following tasks are completed before requesting a review:

  • My code adheres to the coding guidelines of this project.
  • I have run cargo fmt.
  • I have run cargo clippy.
  • I have added or updated tests (if applicable).
  • All CI/CD steps were successful.
  • I have updated the documentation (if applicable).
  • I have checked that there are no console errors or warnings.
  • I have verified that the application builds without errors.
  • I've described the changes made to the API. (modification, addition, deletion).

🚀 Changes Made

  • New Features:
    • Restore received contact invites

📋 Review Guidelines

Please focus on the following while reviewing:

  • Does the code follow the repository's contribution guidelines?
  • Are there any potential bugs or performance issues?
  • Are there any typos or grammatical errors in the code or comments?

@tompro tompro self-assigned this Apr 23, 2026
Copilot AI review requested due to automatic review settings April 23, 2026 08:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds contact-share invite restoration during account recovery by wiring the existing ContactShareEventHandler into the restore flow, so replayed private events recreate pending contact shares.

Changes:

  • Clone push_service when constructing CompanyChainEventProcessor to allow reuse downstream.
  • Instantiate ContactShareEventHandler in create_restore_account_service.
  • Include contact_share_handler in the DirectMessageEventProcessor handlers list used during restore.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.58%. Comparing base (79db6a5) to head (6bdf19e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   70.59%   70.58%   -0.02%     
==========================================
  Files         139      139              
  Lines       27704    27704              
==========================================
- Hits        19557    19554       -3     
- Misses       8147     8150       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tompro tompro merged commit 691eaf1 into master Apr 23, 2026
13 of 14 checks passed
@tompro tompro deleted the account-recovery-contacts branch April 23, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants