Restore contact invites on recover#905
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds contact-share invite restoration during account recovery by wiring the existing ContactShareEventHandler into the restore flow, so replayed private events recreate pending contact shares.
Changes:
- Clone
push_servicewhen constructingCompanyChainEventProcessorto allow reuse downstream. - Instantiate
ContactShareEventHandlerincreate_restore_account_service. - Include
contact_share_handlerin theDirectMessageEventProcessorhandlers list used during restore.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #905 +/- ##
==========================================
- Coverage 70.59% 70.58% -0.02%
==========================================
Files 139 139
Lines 27704 27704
==========================================
- Hits 19557 19554 -3
- Misses 8147 8150 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtbitcr
approved these changes
Apr 23, 2026
zupzup
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds contact share handler to recovery processor. This will add all previously shared contacts into pending contact shares again and allow the user to add them later from the list. We need to keep them pending as we do not know which ones where already accepted (or rejected) before the restore.
Relates to: #699
✅ Checklist
Please ensure the following tasks are completed before requesting a review:
cargo fmt.cargo clippy.🚀 Changes Made
📋 Review Guidelines
Please focus on the following while reviewing: