Fix Derive Address Validation#906
Merged
Merged
Conversation
Collaborator
zupzup
commented
Apr 23, 2026
- The Address derivation endpoint used it's own alpha node id - but we're asking for a specific alpha
- Add logging
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes payment address derivation validation by ensuring the beta mint derives the address using the requested alpha node id (rather than implicitly using its own), and adds error logging to aid debugging in the mint “clowder” flow.
Changes:
- Fetch alpha mint info (
get_info) and passalpha_node_idintoDeriveEbillPaymentAddressRequest. - Add error logs for failures fetching mint info / betas and for address mismatch diagnostics.
- Bump
bcr-commongit revision to a commit that supports the updated request shape/behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/bcr-ebill-api/src/external/mint.rs |
Uses alpha node_id in derive-address request and improves logging around clowder info, betas, and mismatch cases. |
Cargo.toml |
Updates bcr-common git revision to pick up the corresponding wire/API changes. |
mtbitcr
approved these changes
Apr 23, 2026
f78c3ef to
7213731
Compare
7213731 to
f828bdd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
=======================================
Coverage 70.58% 70.58%
=======================================
Files 139 139
Lines 27704 27708 +4
=======================================
+ Hits 19554 19557 +3
- Misses 8150 8151 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.