Skip to content

Upgrade to latest bcr-common clients#907

Merged
zupzup merged 1 commit into
masterfrom
update-bcr-common-clients
Apr 24, 2026
Merged

Upgrade to latest bcr-common clients#907
zupzup merged 1 commit into
masterfrom
update-bcr-common-clients

Conversation

@zupzup
Copy link
Copy Markdown
Collaborator

@zupzup zupzup commented Apr 24, 2026

Adapt to changes in BitcreditProtocol/bcr-common#108 (rev update after merge pending)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace to a newer bcr-common revision and adapts bcr-ebill-api’s external mint integration to the updated clowder client API (per bcr-common PR #108).

Changes:

  • Bump bcr-common git revision in workspace dependencies.
  • Replace post_derive_ebill_payment_address request-struct usage with the new derive_ebill_payment_address(...) call signature in the mint client adapter.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/bcr-ebill-api/src/external/mint.rs Updates clowder API usage to match the new bcr-common client method signature and removes the now-unused request type import.
Cargo.toml Bumps bcr-common git rev to the newer commit referenced by the upstream change.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.57%. Comparing base (3849863) to head (9b679fa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #907   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files         139      139           
  Lines       27708    27708           
=======================================
  Hits        19554    19554           
  Misses       8154     8154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zupzup zupzup force-pushed the update-bcr-common-clients branch from e3a6761 to 9b679fa Compare April 24, 2026 09:16
@zupzup zupzup merged commit fa36d96 into master Apr 24, 2026
10 checks passed
@zupzup zupzup deleted the update-bcr-common-clients branch April 24, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants