Upgrade to latest bcr-common clients#907
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workspace to a newer bcr-common revision and adapts bcr-ebill-api’s external mint integration to the updated clowder client API (per bcr-common PR #108).
Changes:
- Bump
bcr-commongit revision in workspace dependencies. - Replace
post_derive_ebill_payment_addressrequest-struct usage with the newderive_ebill_payment_address(...)call signature in the mint client adapter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/bcr-ebill-api/src/external/mint.rs |
Updates clowder API usage to match the new bcr-common client method signature and removes the now-unused request type import. |
Cargo.toml |
Bumps bcr-common git rev to the newer commit referenced by the upstream change. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #907 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 139 139
Lines 27708 27708
=======================================
Hits 19554 19554
Misses 8154 8154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtbitcr
approved these changes
Apr 24, 2026
e3a6761 to
9b679fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to changes in BitcreditProtocol/bcr-common#108 (rev update after merge pending)