Skip to content

Fixes wrong signer for custom contact files#914

Merged
tompro merged 2 commits into
masterfrom
fix-custom-contact-file-upoad
May 6, 2026
Merged

Fixes wrong signer for custom contact files#914
tompro merged 2 commits into
masterfrom
fix-custom-contact-file-upoad

Conversation

@tompro
Copy link
Copy Markdown
Collaborator

@tompro tompro commented May 5, 2026

📝 Description

Fixes invalid keyset for custom contact file uploads

Relates to #911


✅ Checklist

Please ensure the following tasks are completed before requesting a review:

  • My code adheres to the coding guidelines of this project.
  • I have run cargo fmt.
  • I have run cargo clippy.
  • I have added or updated tests (if applicable).
  • All CI/CD steps were successful.
  • I have updated the documentation (if applicable).
  • I have checked that there are no console errors or warnings.
  • I have verified that the application builds without errors.
  • I've described the changes made to the API. (modification, addition, deletion).

📋 Review Guidelines

Please focus on the following while reviewing:

  • Does the code follow the repository's contribution guidelines?
  • Are there any potential bugs or performance issues?
  • Are there any typos or grammatical errors in the code or comments?

Copilot AI review requested due to automatic review settings May 5, 2026 15:19
@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes contact file uploads for external contacts by ensuring file-metadata publishing uses a node id derived from the available signer keys (instead of the contact’s node id), addressing the “No signer found for node_id: ” failure described in #911.

Changes:

  • Renames the upload-processing parameter to clarify it represents the contact’s node id.
  • When encrypting/saving an uploaded contact file, derives a publisher_node_id from signer.pub_key() and uses it for publishing file metadata events.

Comment thread crates/bcr-ebill-api/src/service/contact_service.rs
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.71%. Comparing base (de6611f) to head (aa0c7da).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
+ Coverage   70.58%   70.71%   +0.13%     
==========================================
  Files         139      139              
  Lines       27708    27714       +6     
==========================================
+ Hits        19557    19599      +42     
+ Misses       8151     8115      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@zupzup zupzup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tompro tompro merged commit 8805c54 into master May 6, 2026
10 checks passed
@tompro tompro deleted the fix-custom-contact-file-upoad branch May 6, 2026 07:10
tompro added a commit that referenced this pull request May 8, 2026
* Fixes wrong signer for custom contact files

* Regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants