Fixes wrong signer for custom contact files#914
Merged
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes contact file uploads for external contacts by ensuring file-metadata publishing uses a node id derived from the available signer keys (instead of the contact’s node id), addressing the “No signer found for node_id: ” failure described in #911.
Changes:
- Renames the upload-processing parameter to clarify it represents the contact’s node id.
- When encrypting/saving an uploaded contact file, derives a
publisher_node_idfromsigner.pub_key()and uses it for publishing file metadata events.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 70.58% 70.71% +0.13%
==========================================
Files 139 139
Lines 27708 27714 +6
==========================================
+ Hits 19557 19599 +42
+ Misses 8151 8115 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtbitcr
approved these changes
May 6, 2026
tompro
added a commit
that referenced
this pull request
May 8, 2026
* Fixes wrong signer for custom contact files * Regression test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes invalid keyset for custom contact file uploads
Relates to #911
✅ Checklist
Please ensure the following tasks are completed before requesting a review:
cargo fmt.cargo clippy.📋 Review Guidelines
Please focus on the following while reviewing: