Skip to content

Rename Mandatory Emails Flag#916

Merged
zupzup merged 1 commit into
masterfrom
zupzup/876-rename-mandatory-emails-flag
May 12, 2026
Merged

Rename Mandatory Emails Flag#916
zupzup merged 1 commit into
masterfrom
zupzup/876-rename-mandatory-emails-flag

Conversation

@zupzup
Copy link
Copy Markdown
Collaborator

@zupzup zupzup commented May 12, 2026

  • Change the flag to a reasonable name
  • Fix wasm-pack install script

@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the E-Bills WASM/API configuration surface by renaming the developer-mode email-confirmation flag to a clearer name, and adjusts GitHub Actions to install wasm-pack via Cargo rather than a custom installer script.

Changes:

  • Renamed disable_mandatory_email_confirmationsmandatory_email_confirmations across WASM config, API config, and related services/tests.
  • Removed the custom wasm-pack installer script and switched CI workflows to cargo install wasm-pack.
  • Documented the breaking config rename in the changelog.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
scripts/install-wasm-pack.sh Removed legacy installer script (no longer used by CI).
crates/bcr-ebill-wasm/src/lib.rs Exposes renamed config field through the WASM boundary and forwards it into DevModeConfig.
crates/bcr-ebill-wasm/main.js Updates example config to use mandatory_email_confirmations.
crates/bcr-ebill-transport/src/test_utils.rs Updates test config construction for renamed flag.
crates/bcr-ebill-api/src/tests/mod.rs Updates API tests to use renamed flag.
crates/bcr-ebill-api/src/service/identity_service.rs Uses the renamed flag when enforcing confirmed-email requirements.
crates/bcr-ebill-api/src/service/company_service.rs Uses the renamed flag when enforcing confirmed-email requirements for company signatories.
crates/bcr-ebill-api/src/service/bill_service/data_fetching.rs Updates dev-mode witness-selection logic to the renamed flag.
crates/bcr-ebill-api/src/lib.rs Renames the DevModeConfig field to mandatory_email_confirmations.
CHANGELOG.md Notes the breaking config rename and intended default behavior.
.github/workflows/wasm_release.yml Installs wasm-pack via cargo install wasm-pack.
.github/workflows/rust.yml Installs wasm-pack via cargo install wasm-pack for CI WASM builds.

Comment thread crates/bcr-ebill-api/src/lib.rs
Comment thread .github/workflows/wasm_release.yml Outdated
Comment thread .github/workflows/rust.yml Outdated
Comment thread crates/bcr-ebill-api/src/service/company_service.rs
Comment thread crates/bcr-ebill-api/src/service/identity_service.rs
@zupzup zupzup force-pushed the zupzup/876-rename-mandatory-emails-flag branch from 6b624dc to 3cf45b4 Compare May 12, 2026 11:35
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.72%. Comparing base (674673f) to head (3cf45b4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   70.74%   70.72%   -0.03%     
==========================================
  Files         139      139              
  Lines       27713    27705       -8     
==========================================
- Hits        19606    19594      -12     
- Misses       8107     8111       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zupzup zupzup merged commit 448f5fa into master May 12, 2026
9 of 10 checks passed
@zupzup zupzup deleted the zupzup/876-rename-mandatory-emails-flag branch May 12, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants