Rename Mandatory Emails Flag#916
Merged
Merged
Conversation
Collaborator
zupzup
commented
May 12, 2026
- Change the flag to a reasonable name
- Fix wasm-pack install script
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the E-Bills WASM/API configuration surface by renaming the developer-mode email-confirmation flag to a clearer name, and adjusts GitHub Actions to install wasm-pack via Cargo rather than a custom installer script.
Changes:
- Renamed
disable_mandatory_email_confirmations→mandatory_email_confirmationsacross WASM config, API config, and related services/tests. - Removed the custom
wasm-packinstaller script and switched CI workflows tocargo install wasm-pack. - Documented the breaking config rename in the changelog.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/install-wasm-pack.sh | Removed legacy installer script (no longer used by CI). |
| crates/bcr-ebill-wasm/src/lib.rs | Exposes renamed config field through the WASM boundary and forwards it into DevModeConfig. |
| crates/bcr-ebill-wasm/main.js | Updates example config to use mandatory_email_confirmations. |
| crates/bcr-ebill-transport/src/test_utils.rs | Updates test config construction for renamed flag. |
| crates/bcr-ebill-api/src/tests/mod.rs | Updates API tests to use renamed flag. |
| crates/bcr-ebill-api/src/service/identity_service.rs | Uses the renamed flag when enforcing confirmed-email requirements. |
| crates/bcr-ebill-api/src/service/company_service.rs | Uses the renamed flag when enforcing confirmed-email requirements for company signatories. |
| crates/bcr-ebill-api/src/service/bill_service/data_fetching.rs | Updates dev-mode witness-selection logic to the renamed flag. |
| crates/bcr-ebill-api/src/lib.rs | Renames the DevModeConfig field to mandatory_email_confirmations. |
| CHANGELOG.md | Notes the breaking config rename and intended default behavior. |
| .github/workflows/wasm_release.yml | Installs wasm-pack via cargo install wasm-pack. |
| .github/workflows/rust.yml | Installs wasm-pack via cargo install wasm-pack for CI WASM builds. |
cleot
approved these changes
May 12, 2026
stefanbitcr
approved these changes
May 12, 2026
6b624dc to
3cf45b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 70.74% 70.72% -0.03%
==========================================
Files 139 139
Lines 27713 27705 -8
==========================================
- Hits 19606 19594 -12
- Misses 8107 8111 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.