Upgrade to Latest bcr-common#917
Merged
Merged
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace dependency on bcr-common to a newer git revision and aligns bcr-ebill-api’s external mint integration with the updated bcr-common API/types by removing now-unnecessary local wire reply wrappers.
Changes:
- Bump
bcr-commonto rev3359dd7e…in workspaceCargo.toml. - Simplify beta mint URL handling in
validate_payment_address_from_mintby using the returned mint URL directly (no re-parsing). - Remove unused clowder wire reply structs/imports that are no longer referenced.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/bcr-ebill-api/src/external/mint.rs |
Adapts mint beta URL usage to updated bcr-common types and removes unused clowder response wrapper types/imports. |
Cargo.toml |
Updates the workspace bcr-common git revision. |
stefanbitcr
approved these changes
May 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #917 +/- ##
==========================================
+ Coverage 70.71% 70.73% +0.02%
==========================================
Files 139 139
Lines 27705 27696 -9
==========================================
Hits 19591 19591
+ Misses 8114 8105 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just latest bcr-common to keep up and delete some unused stuff