Skip to content

Upgrade to Latest bcr-common#917

Merged
zupzup merged 1 commit into
masterfrom
zupzup/latest-bcr-common
May 12, 2026
Merged

Upgrade to Latest bcr-common#917
zupzup merged 1 commit into
masterfrom
zupzup/latest-bcr-common

Conversation

@zupzup
Copy link
Copy Markdown
Collaborator

@zupzup zupzup commented May 12, 2026

Just latest bcr-common to keep up and delete some unused stuff

@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the workspace dependency on bcr-common to a newer git revision and aligns bcr-ebill-api’s external mint integration with the updated bcr-common API/types by removing now-unnecessary local wire reply wrappers.

Changes:

  • Bump bcr-common to rev 3359dd7e… in workspace Cargo.toml.
  • Simplify beta mint URL handling in validate_payment_address_from_mint by using the returned mint URL directly (no re-parsing).
  • Remove unused clowder wire reply structs/imports that are no longer referenced.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/bcr-ebill-api/src/external/mint.rs Adapts mint beta URL usage to updated bcr-common types and removes unused clowder response wrapper types/imports.
Cargo.toml Updates the workspace bcr-common git revision.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.73%. Comparing base (448f5fa) to head (833afc1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   70.71%   70.73%   +0.02%     
==========================================
  Files         139      139              
  Lines       27705    27696       -9     
==========================================
  Hits        19591    19591              
+ Misses       8114     8105       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zupzup zupzup merged commit 2a4f660 into master May 12, 2026
14 checks passed
@zupzup zupzup deleted the zupzup/latest-bcr-common branch May 12, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants