fix: normalize BGL bridge submit endpoint#2
Open
tolga-tom-nook wants to merge 1 commit into
Open
Conversation
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes the BGL bridge submit endpoint before appending
/submit/bgl.The default bridge endpoint includes a trailing slash:
But
_submitToBridgeappended another slash:`${this.bridgeEndpoint}/submit/bgl`That produces
https://bglswap.com/app//submit/bglfor the default/configured endpoint. This PR trims trailing slashes first so bothhttps://bglswap.com/app/andhttps://bglswap.com/appresolve to the canonicalhttps://bglswap.com/app/submit/bglURL.Validation
Focused regression test:
Result:
Targeted lint:
Result: passed.
Diff hygiene:
Result: clean.
Note:
npm run buildis currently blocked by the repo's dependency/toolchain mismatch after fresh install (@types/noderequires disposable lib symbols not available to the pinned TypeScript 4.9 toolchain). The focused Jest regression and targeted ESLint pass for this change.Bounty context: Bitgesell PR bounty/improvement program.