fix: return transaction objects on repeated bridge swaps#4
Open
newmattock wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transaction.makeTxObject()so it returns a fresh Bitgesell transaction object on every call, not only during the first SDK initialization.undefined.Verification
pnpm exec jest src/__tests__/Transaction.test.ts --runInBandpnpm exec tsc --noEmit --skipLibCheck --module commonjs --target es2019 --esModuleInterop --types jest src/bridge/Transaction.ts src/__tests__/Transaction.test.tspnpm exec prettier --check src/bridge/Transaction.ts src/__tests__/Transaction.test.tsgit diff --checkNotes
pnpm exec tsc -p tsconfig.json --skipLibCheckcurrently fails on upstream because the repo'stsconfig.jsonreferences thenodetype package but@types/nodeis not declared as a visible dependency in this install. The focused compile command above covers the changed source and regression test.pnpm exec eslint src/bridge/Transaction.ts src/__tests__/Transaction.test.ts --ext .tsdid not complete locally after roughly 45 seconds and was stopped.Bounty context
Submitted for Bitgesell improvement bounty consideration: BitgesellOfficial/bitgesell#39.