Skip to content

fix: return transaction objects on repeated bridge swaps#4

Open
newmattock wants to merge 1 commit into
BitgesellOfficial:mainfrom
newmattock:codex/wbgl-transaction-factory-reuse
Open

fix: return transaction objects on repeated bridge swaps#4
newmattock wants to merge 1 commit into
BitgesellOfficial:mainfrom
newmattock:codex/wbgl-transaction-factory-reuse

Conversation

@newmattock
Copy link
Copy Markdown

Summary

  • Fix Transaction.makeTxObject() so it returns a fresh Bitgesell transaction object on every call, not only during the first SDK initialization.
  • Add a focused regression test proving repeated factory calls no longer return undefined.

Verification

  • pnpm exec jest src/__tests__/Transaction.test.ts --runInBand
  • pnpm exec tsc --noEmit --skipLibCheck --module commonjs --target es2019 --esModuleInterop --types jest src/bridge/Transaction.ts src/__tests__/Transaction.test.ts
  • pnpm exec prettier --check src/bridge/Transaction.ts src/__tests__/Transaction.test.ts
  • git diff --check

Notes

  • pnpm exec tsc -p tsconfig.json --skipLibCheck currently fails on upstream because the repo's tsconfig.json references the node type package but @types/node is not declared as a visible dependency in this install. The focused compile command above covers the changed source and regression test.
  • pnpm exec eslint src/bridge/Transaction.ts src/__tests__/Transaction.test.ts --ext .ts did not complete locally after roughly 45 seconds and was stopped.

Bounty context

Submitted for Bitgesell improvement bounty consideration: BitgesellOfficial/bitgesell#39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant