Repository navigation
feat(adaptive-delivery): add host configuration doctor - #167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Adaptive Delivery needs a read-only way to explain host delegation failures without accidentally activating orchestration. This addresses the effective-config, concurrency, and nesting diagnosis requested in #161 while aligning the implementation with Darrow's current contained Python mechanics.
What changed
Adds the self-contained
doctor-adaptive-deliveryskill for Codex and Claude Code and derives baseline and full-path capacity from the documented delegation topology. The deterministic doctor now lives in the existingdarrow-adaptive-deliveryPython package, uses frozen UV entrypoints and standard TOML parsing with a Python 3.10 backport, supports native Windows configuration discovery, and removes the Bash runtime implementation. The branch also updates the normative invariant, discovery and troubleshooting docs, representative evals, copied-plugin coverage, and both plugin manifests to version 0.23.0.Verification
bun run check:pythonpassed across every registered package; the changed Adaptive Delivery package passed 205 tests with 98.84% line and 97.55% branch coverage. The fresh copied plugin passed with runtime-only dependencies, the skill inspector and Claude manifest validator passed, and docs, Prettier, ESLint, TypeScript, shell lint, decisions, and diff checks passed. Both-host five-case dry evals prepared successfully; focused live Codex and Claude trials each passed task and activation checks. Repository-widebun teststill contains the unrelatedevals/runner/discovery-eval-checks.test.tsplanning-transfer failure (expected false, receivedundefined), reproduced in isolation.Review notes
The highest-risk code is the host-configuration parser and capacity derivation in
backend/src/darrow_adaptive_delivery/doctor.py. Tests cover malformed and wrongly typed TOML, unreadable and absent files, isolatedCODEX_HOME, native WindowsUSERPROFILE, V1/V2 depth behavior, Claude version boundaries and defaults, redaction, complete remediation guidance, command exits, and copied runtime-only installation. Native Windows behavior is covered by the repository's Python matrix; this local verification ran on macOS.Checklist
CONTRIBUTING.md, including the contributionlicensing terms.
this change does not affect a capability invariant.
behavior.
change does not affect plugin content.
bun run check:python, or this change does not affect registeredPython packages or their repository quality infrastructure.