feat(verification): adopt Python renderer mechanics - #192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #177. The verification assessment renderer was the remaining shell-based deterministic mechanic in the plugin, limiting the shared Python quality gates and native Windows coverage established by #172.
What changed
Replaced the shell renderer with a dependency-free, UV-locked Python package while preserving its accepted inputs, byte-stable assessment body, exact report-link format, validation diagnostics, and exit statuses. Added invariant VF-C8, focused example and property tests, copied-plugin fresh-install tests for POSIX and PowerShell, repository Python-quality and CI wiring, stricter renderer-output eval checks, documentation updates, and matching plugin version 0.2.0 manifests.
Verification
bun run check:python— passed; verification backend: 33 tests with 100% line and branch coverage.bun run lint,bun run lint:ts,bun run lint:shell,bun run typecheck,bun run check:decisions, andbun run check:docs— passed.scripts/test-python-quality-changesandscripts/verify-python-quality-resultscoverage exercised through the repository Python gate — passed.bash plugins/capability/darrow-verification/tests/fresh-install.test.sh— passed./bin/bash plugins/capability/darrow-verification/tests/fresh-install.test.sh— passed.claude plugin validate plugins/capability/darrow-verification— passed.Review notes
The highest-risk surface is cross-platform path handling and exact byte rendering in
assessment.py; focused unit, property, copied-install, and eval coverage target those contracts. Native Windows execution is wired into the Python package and fresh-install CI matrices; local host verification was performed on macOS.Checklist
CONTRIBUTING.md, including the contributionlicensing terms.
this change does not affect a capability invariant.
behavior.
change does not affect plugin content.
bun run check:python, or this change does not affect registeredPython packages or their repository quality infrastructure.