Repository navigation
fix: move Darrow state into user directories - #238
Merged
Merged
Conversation
Keep review evidence outside Git directories with bounded retention and dependency-preserving cleanup. Place locked UV environments in the sibling user cache. Leave existing files in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #225. Review artifacts stored under repository Git directories have an unclear lifetime. Put Darrow state under one user-local root and make review cleanup explicit. This also updates the default UV project-environment location from the already implemented #226.
What changed
~/.darrow/reviews/on macOS/Linux or%LOCALAPPDATA%\Darrow\Reviews\on Windows, with repository/worktree buckets, unique runs, and private permissions where supported. KeepDARROW_REVIEW_STATE_DIRas an absolute-path override.~/.darrow/cache/or%LOCALAPPDATA%\Darrow\Cache\. PreserveDARROW_CACHE_DIR; leaveUV_CACHE_DIRunder UV or caller control.Verification
bun run check:pythonpassed across all 12 packages; darrow-review: 229 tests, 96.82% line and 95.73% branch coverage.bun run lint,bun run check:docs,bun run lint:ts,bun run typecheck, andgit diff --checkpassed.bun run test:eval-runner-compatibility: 5 passed.code-review-empty-difflive eval passed task and activation (1/1); no matched control was required for this focused run.empty-difffailed activation, and explicitreviewer-route-unavailableactivated the skill but did not produce its required artifact commands. These are open skill-behavior verification limits./bin/bashscript checks do not apply.Review notes
No migration runs. Files in previous Git and UV locations remain untouched. Review evidence is retained until eligible for 30-day pruning; cache files are disposable and managed separately. Windows behavior has unit coverage with simulated platform paths and locking; it was not run on a native Windows host. Review
darrow_review/storage.pyand the eval runner state isolation for the highest-risk changes.Checklist
CONTRIBUTING.md, including the contribution licensing terms.bun run check:python, or this change does not affect registered Python packages or their repository quality infrastructure.