refactor(review)!: replace TSV artifacts with JSON records - #244
Merged
Merged
Conversation
BREAKING CHANGE: Review record files now use JSON arrays and v2 format IDs.
BREAKING CHANGE: Review machine artifacts now use named v3 JSON objects. Retained v2 state is read only for pruning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TSV review records cannot preserve tabs or newlines in paths, commands, and check evidence. Valid review input was rejected or flattened at the artifact boundary.
What changed
Review artifacts now use UTF-8 JSON arrays of string records at .json paths with v2 protocol IDs. Parsing and validation preserve embedded tabs and newlines; Markdown rendering escapes them for a stable report. The review specification, skill instructions, fixtures, runner proof readers, and Adaptive Delivery and Verify Change consumers were updated. The three changed plugin manifests were versioned together within each plugin.
Verification
bun run check:python— passed, including 237 darrow-review and 214 Adaptive Delivery backend tests.bun test— 641 passed, including review outcome eval checks underbashand/bin/bash.bun run lint,bun run lint:ts,bun run lint:shell,bun run typecheck,bun run check:decisions, andbun run check:docs— passed.Review notes
Breaking change: v1 TSV artifacts are not accepted; installed review consumers need the matching JSON update. The eval-only fixture adapters retain tab-oriented assertions and can flatten distinctions between embedded control characters and literal escape text; production round-trip tests cover these values, and direct JSON eval assertions are a follow-up cleanup.
Checklist
CONTRIBUTING.md, including the contributionlicensing terms.
this change does not affect a capability invariant.
behavior.
change does not affect plugin content.
bun run check:python, or this change does not affect registeredPython packages or their repository quality infrastructure.