Skip to content

security: require patched Starlette#1249

Merged
Blaizzy merged 1 commit into
Blaizzy:mainfrom
Thump604:604/badhost-starlette-floor
May 30, 2026
Merged

security: require patched Starlette#1249
Blaizzy merged 1 commit into
Blaizzy:mainfrom
Thump604:604/badhost-starlette-floor

Conversation

@Thump604
Copy link
Copy Markdown
Contributor

Summary

  • Add an explicit starlette>=1.0.1 dependency floor.
  • Refresh uv.lock so the locked server/UI stack resolves to patched Starlette.

Why

Starlette versions below the patched BadHost floor have a Host-header URL parsing vulnerability. mlx-vlm already depends on FastAPI, but the project dependency file did not directly express a patched Starlette floor, and the lock file still resolved starlette==0.50.0.

Validation

  • Checked current server source for request.url / request.url.path usage; none found in mlx_vlm server code.
  • uv lock --check passed.
  • Resolver dry-run for the UI extra on Python 3.12 completed successfully:
    uv pip install --python /tmp/mlx-vlm-badhost-resolve/bin/python --dry-run '.[ui]'
  • The resolved set selected fastapi==0.136.3, gradio==6.15.2, and starlette==1.2.0.
  • git diff --check passed.

Explicit non-claims

  • This PR does not claim an application-level BadHost exploit in mlx-vlm.
  • This PR does not change server behavior.
  • This PR only hardens dependency resolution and the lock file.

Copy link
Copy Markdown
Owner

@Blaizzy Blaizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Blaizzy Blaizzy merged commit 8de29d4 into Blaizzy:main May 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants