Repository navigation
feat(theme): prioritize user themes over embedded themes and add white theme - #47
Conversation
|
Confidence: 5/5Checks run: SummaryUpdate: I pushed Thanks Felipe, nice and tight. This moves user themes ( Mapflowchart LR
W[src/themes/white.json] -->|include_dir CUSTOM_THEMES_DIR| L[load_color_themes]
U[user themes dir] --> D[discover_user_themes]
D --> L
U --> LU[load_user_theme]
LU --> T[ColorTheme::to_theme]
W --> T
L --> G[gui/mod.rs theme picker]
T --> G
Regressions
MigrationsNone. No config keys or formats change. New Before merging
|
Blankeos
left a comment
There was a problem hiding this comment.
Approved after review and checks (see the pr-review comment).
Summary
~/.config/lazygitrs/themes/*.json(and~/.config/lazygit/themes/*.json) over compile-time embedded themes. Previously, embedded themes were checked first in bothload_color_themes()andColorTheme::to_theme(), preventing users from overriding existing themes with custom palettes.WhiteTheme: Addssrc/themes/white.json, providing a clean, pure black-on-white high-contrast theme suited for bright daylight and e-ink displays.whitetheme is discovered, resolves withThemeAppearance::Light, and initializes expected color properties.Verification
cargo fmtchecked.cargo test --bin lazygitrs(373 passed).