Skip to content

Revert "feat: add Forge app endpoints for Jira event trigger and run status"#69

Merged
woywro merged 1 commit into
devfrom
revert-68-feat/jira-forge-app
May 7, 2026
Merged

Revert "feat: add Forge app endpoints for Jira event trigger and run status"#69
woywro merged 1 commit into
devfrom
revert-68-feat/jira-forge-app

Conversation

@woywro
Copy link
Copy Markdown
Collaborator

@woywro woywro commented May 7, 2026

Reverts #68

Summary by CodeRabbit

  • Removals
    • Removed Jira Forge shared-secret authentication configuration option from the system.
    • Removed Jira dispatch and runs query endpoints.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@woywro woywro merged commit 9ebbec5 into dev May 7, 2026
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f8b9a42b-6fc5-47b3-ad0f-75da827f63ea

📥 Commits

Reviewing files that changed from the base of the PR and between 8e8382d and 57220a5.

📒 Files selected for processing (3)
  • env.ts
  • src/routes/jira/dispatch.post.ts
  • src/routes/runs/[key].get.ts

📝 Walkthrough

Walkthrough

This PR removes Forge-based authentication infrastructure from the codebase. The FORGE_SHARED_SECRET environment variable is deleted from the schema, and two route handlers—the Jira dispatch endpoint and the runs API handler—are removed entirely.

Changes

Remove Forge-based Authentication

Layer / File(s) Summary
Environment Schema Update
env.ts
Removed optional FORGE_SHARED_SECRET field from env.server schema; Jira webhook secret and Redis configuration remain.
Jira Dispatch Endpoint Removal
src/routes/jira/dispatch.post.ts
Deleted POST route handler that authenticated requests using x-forge-secret header with constant-time comparison and dispatched Jira tickets.
Runs API Handler Removal
src/routes/runs/[key].get.ts
Deleted GET route handler for retrieving workflow run status and metadata by key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Blazity/ai-workflow#68: Main PR that adds FORGE_SHARED_SECRET environment variable and Jira Forge route handlers; this deletion PR appears to be the reverse or a related cleanup.

Poem

🐰 Forge secrets fade to past,
Routes deleted, auth won't last,
Config pruned with steady hand,
Cleaner code throughout the land! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@woywro woywro deleted the revert-68-feat/jira-forge-app branch May 8, 2026 05:12
@coderabbitai coderabbitai Bot mentioned this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant