Skip to content

fix(network): bound gethostname copy to guest namelen #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
midwan merged 1 commit into from
Sep 15, 2026
+12 −2
Merged

fix(network): bound gethostname copy to guest namelen #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/bsdsocket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2144,13 +2144,23 @@ uae_u32 host_Inet_MakeAddr(uae_u32 net, uae_u32 host)

uae_u32 host_gethostname(TrapContext *ctx, uae_u32 name, uae_u32 namelen)
{
char buf[256];
size_t len;

if (!trap_valid_address(ctx, name, namelen))
return -1;
char buf[256];
if (namelen == 0)
return -1;
if (gethostname(buf, sizeof(buf)) != 0)
return -1;
buf[sizeof(buf) - 1] = '\0';
trap_put_string(ctx, (uae_char *)buf, name, namelen);
len = strlen(buf);
if (len >= namelen)
len = namelen - 1; /* caller's buffer too small: truncate */
buf[len] = '\0';
/* trap_put_string() copies through the terminating NUL and ignores its
* maxlen on the direct-memory path, so use a strictly bounded copy */
trap_put_bytes(ctx, buf, name, (int)(len + 1));
return 0;
}

Expand Down