build(macos): bundle libSDL3.dylib for sdl2-compat - #43
Merged
Merged
Conversation
Homebrew's sdl2 formula ships sdl2-compat (2.32+), which dlopens libSDL3.dylib at runtime, trying @loader_path first. dylibbundler only walks LC_LOAD_DYLIB entries, so SDL3 never landed in the app bundle and launch died with "Failed loading SDL3 library.". After dylibbundler runs, detect sdl2-compat in the bundled libSDL2 (it embeds the dlopen name libSDL3.dylib; real SDL2 does not), copy libSDL3.dylib next to it from the Homebrew prefix, and re-sign the bundle so the seal stays valid. Real-SDL2 builds are untouched.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0360c9193c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Per review: --deep on the executable does not regenerate the enclosing bundle's resource seal. Sign nested code (libSDL3.dylib) first, then the .app itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reproducing #3 on macOS.
Problem
Launching the macOS app bundle shows "Fatal error: failed loading SDL3 library" and never starts.
Homebrew's
sdl2formula now installs sdl2-compat (2.32.x), which implements the SDL2 API on top of SDL3 anddlopen()slibSDL3.dylibat runtime (first candidate:@loader_path/libSDL3.dylib). The bundle's gathering step (dylibbundler) only walksLC_LOAD_DYLIBentries, so SDL3 is a hidden dependency it cannot see — it never gets copied intoFrameworks/, and the app dies on launch.Fix
New post-build step (
cmake/macos/BundleSDL3Compat.cmake), running after dylibbundler:libSDL2-2.0.0.dylib(it embeds the literal dlopen namelibSDL3.dylib; real SDL2 does not).libSDL3.dylib(hints: the linked SDL2's directory, Homebrew prefixes) and copies it intoFrameworks/, warning at build time if SDL3 is missing.Builds against real SDL2 are untouched (script exits early).
Verification
libSDL3.dylib,codesign -v --deeppasses, app boots to emulation with no manual patching (previously required a hand-copied dylib).