toolbox: Skip DATA_OUT phase on zero-length SET_WORKING_DIR#361
Merged
erichelgeson merged 1 commit intomainfrom Apr 27, 2026
Merged
toolbox: Skip DATA_OUT phase on zero-length SET_WORKING_DIR#361erichelgeson merged 1 commit intomainfrom
erichelgeson merged 1 commit intomainfrom
Conversation
CDB[8]=0 on SET_WORKING_DIR now returns STATUS with no state change, matching the SCSI-2 convention already used by MODE SELECT a parameter list length of zero means no data shall be transferred and shall not be treated as an error. Clients that want to reset the override must continue to send a 1-byte NUL path explicitly (CDB[8]=1, data=0x00). An all-NUL multi-byte payload (e.g. CDB[8]=4 with four NUL bytes) resets as well. Thanks saybur!
BlueSCSI Memory ReportCompared against release Memory Usage
Symbol Region ChangesPico_2_Audio_SPDIF: 3 symbols moved FLASH → RAM (+12 B)
Pico_2_Audio_SPDIF: 9 symbols moved RAM → FLASH (-298 B RAM)
Pico_2_DaynaPORT: 3 symbols moved FLASH → RAM (+12 B)
Pico_2_DaynaPORT: 9 symbols moved RAM → FLASH (-298 B RAM)
Pico_Audio_SPDIF: 13 symbols moved FLASH → RAM (+2.0 KB)
Pico_Audio_SPDIF: 43 symbols moved RAM → FLASH (-5.3 KB RAM)
Pico_DaynaPORT: 34 symbols moved FLASH → RAM (+7.2 KB)
Pico_DaynaPORT: 3 symbols moved RAM → FLASH (-1.2 KB RAM)
Ultra: 4 symbols moved FLASH → RAM (+16 B)
Ultra: 9 symbols moved RAM → FLASH (-298 B RAM)
Ultra_Wide: 4 symbols moved FLASH → RAM (+16 B)
Ultra_Wide: 9 symbols moved RAM → FLASH (-298 B RAM)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDB[8]=0 on SET_WORKING_DIR now returns STATUS with no state change, matching the SCSI-2 convention already used by MODE SELECT a parameter list length of zero means no data shall be transferred and shall not be treated as an error.
Clients that want to reset the override must continue to send a 1-byte NUL path explicitly (CDB[8]=1, data=0x00). An all-NUL multi-byte payload (e.g. CDB[8]=4 with four NUL bytes) resets as well.
Thanks saybur!