Other Fixes by erichelgeson · Pull Request #364 · BlueSCSI/BlueSCSI-v2

erichelgeson · 2026-04-27T23:53:42Z

Putting some resources here for others who might not know that just adding a Co-authored-by: to a commit is not the same as preserving the author.

Every commit has both an author (who wrote the change) and a committer (who applied it) — they're stored as separate metadata and are allowed to differ. Co-authored-by: is just a trailer in the commit message body - it does not change the author field, so git log and git blame will still show whoever ran git commit as the author.

Cherry-pick allows you to pick commits from any remote, even if they've diverged. Preserves the original author and sets you as the committer automatically:

https://git-scm.com/docs/git-cherry-pick

You can format a patch then apply it with git am (which preserves authorship from the patch metadata) and resolve conflicts if necessary.

If you accidentally commit the wrong author or manually apply a patch, you can --amend or commit it using --author:

https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---authorauthor

There will of course be situations where this can get complex but normally it's pretty straight forward.

HTH

This PR is various fixes (see individual commits) with authors correctly preserved. Thanks!

The log mask was a uint8_t defaulting to 0xFF with the selected ID masked by & 7, so any future build with S2S_MAX_TARGETS > 8 would silently drop debug logging for IDs 8-15. Introduce BLUESCSI_DEFAULT_LOG_MASK = ((1UL << S2S_MAX_TARGETS) - 1UL), widen g_scsi_log_mask to uint32_t, and mask the selected ID by (S2S_MAX_TARGETS - 1) so the mask tracks target count automatically. Cherry-picked from d3bd45c26.

Previously the SCSI trace only logged the decoded command name, so any opcode not present in getCommandName() produced 'COMMAND: Unknown' with no way to tell which opcode was actually received without correlating the next OUT hex dump line. Emit the opcode byte as a hex literal followed by the decoded name in parentheses, for example: ---- COMMAND: 0x12 (Inquiry) ---- COMMAND: 0xDE (Unknown) This keeps each COMMAND trace line self-contained and makes unknown opcodes directly actionable. Cherry-picked from c73f394aad.

Only clone SCSI peripheral types that may be block types and print the full name of those types. Cherry-picked from 624d74777.

Scan SCSI IDs 8-15 in addition to 0-7 on wide bus builds, and encode the target ID in the imaged filename as a single character: '0'-'9' for 0-9, 'A'-'F' for 10-15. A hard drive at SCSI ID 11 becomes HDB0_imaged.hda. Cherry-picked from f528c2403, b6616ffb0.

github-actions · 2026-04-27T23:59:16Z

BlueSCSI Memory Report

Compared against release v2026.03.01

Memory Usage

Target	FLASH	RAM	SCRATCH_X	SCRATCH_Y
Pico_2_Audio_SPDIF	674.8 KB (+54.8 KB) [33%]	511.7 KB [100%]	3.5 KB [88%]	3.8 KB (+1.0 KB) [94%]
Pico_2_DaynaPORT	667.1 KB (+53.7 KB) [33%]	511.7 KB [100%]	3.5 KB [88%]	3.0 KB (+1.0 KB) [75%]
Pico_Audio_SPDIF	696.4 KB (+62.6 KB) [34%]	252.3 KB (+6.8 KB) [99%]	1.5 KB [38%]	768 B [19%]
Pico_DaynaPORT	688.2 KB (+62.0 KB) [34%]	246.0 KB (+15.8 KB) [96%]	1.5 KB [38%]	—
Ultra	684.1 KB (+59.1 KB) [33%]	511.7 KB [100%]	3.5 KB [88%]	3.0 KB (+1.0 KB) [75%]
Ultra_Wide	444.0 KB (+63.2 KB) [22%]	511.7 KB [100%]	2.0 KB [50%]	3.0 KB (+1.0 KB) [75%]

Symbol Region Changes

Pico_2_Audio_SPDIF: 3 symbols moved FLASH → RAM (+12 B)

Symbol	Size
`operator delete(void*, unsigned int)`	4 B
`operator new[](unsigned int)`	4 B
`operator delete[](void*)`	4 B

Pico_2_Audio_SPDIF: 9 symbols moved RAM → FLASH (-298 B RAM)

Symbol	Size
`tud_descriptor_device_cb`	116 B
`tud_descriptor_string_cb`	96 B
`_fstat`	16 B
`_lseek`	16 B
`_close`	16 B
`_isatty`	16 B
`tud_descriptor_configuration_cb`	12 B
`_read`	6 B
`_write`	4 B

Pico_2_DaynaPORT: 3 symbols moved FLASH → RAM (+12 B)

Symbol	Size
`operator delete(void*, unsigned int)`	4 B
`operator new[](unsigned int)`	4 B
`operator delete[](void*)`	4 B

Pico_2_DaynaPORT: 9 symbols moved RAM → FLASH (-298 B RAM)

Symbol	Size
`tud_descriptor_device_cb`	116 B
`tud_descriptor_string_cb`	96 B
`_fstat`	16 B
`_lseek`	16 B
`_close`	16 B
`_isatty`	16 B
`tud_descriptor_configuration_cb`	12 B
`_read`	6 B
`_write`	4 B

Pico_Audio_SPDIF: 13 symbols moved FLASH → RAM (+2.0 KB)

Symbol	Size
`mscd_xfer_cb`	1.4 KB
`mscd_control_xfer_cb`	328 B
`tud_descriptor_string_cb`	116 B
`mscd_open`	104 B
`mscd_reset`	20 B
`mscd_init`	20 B
`tud_descriptor_configuration_cb`	8 B
`operator delete(void*, unsigned int)`	8 B
`operator new[](unsigned int)`	8 B
`tud_descriptor_device_cb`	8 B
`operator delete[](void*)`	8 B
`exit`	6 B
`SdSpiCard::errorCode() const`	4 B

Pico_Audio_SPDIF: 43 symbols moved RAM → FLASH (-5.3 KB RAM)

Symbol	Size
`amigaWifiCommand`	1.2 KB
`FatFile::rename(FatFile, char const)`	332 B
`FatPartition::init(FsBlockDeviceInterface*, unsigned char, unsigned long)`	324 B
`ExFatPartition::init(FsBlockDeviceInterface*, unsigned char, unsigned long)`	252 B
`ExFatFile::addDirCluster()`	196 B
`ExFatPartition::bitmapFind(unsigned long, unsigned long)`	192 B
`partitionTableGetVolumeStartSector(FsCache&, unsigned char)`	192 B
`ExFatPartition::bitmapModify(unsigned long, unsigned long, bool)`	164 B
`FatFile::makeUniqueSfn(FatLfn_t*)`	144 B
`ExFatFile::rename(ExFatFile, char const)`	140 B
`ExFatFile::preAllocate(unsigned long long)`	136 B
`ExFatPartition::freeClusterCount()`	136 B
`FatPartition::allocContiguous(unsigned long, unsigned long*)`	136 B
`FatPartition::freeClusterCount()`	124 B
`FatPartition::allocateCluster(unsigned long, unsigned long*)`	124 B
`FatFile::addDirCluster()`	112 B
`FatFile::fgets(char, int, char const)`	106 B
`FatFile::contiguousRange(unsigned long, unsigned long)`	106 B
`ExFatFile::fgets(char, int, char const)`	104 B
`FatPartition::fatPut(unsigned long, unsigned long)`	104 B
`FsBaseFile::copy(FsBaseFile const*)`	102 B
`ExFatPartition::fatPut(unsigned long, unsigned long)`	80 B
`ExFatPartition::freeChain(unsigned long)`	78 B
`ExFatFile::contiguousRange(unsigned long, unsigned long)`	76 B
`FatVolume::chdir(char const*)`	72 B
`FatFile::preAllocate(unsigned long)`	72 B
`ExFatVolume::chdir(char const*)`	68 B
`FatPartition::freeChain(unsigned long)`	58 B
`FatFile::getLfnChar(DirLfn_t const*, unsigned char)`	52 B
`ExFatFile::peek()`	50 B
... and 13 more

Pico_DaynaPORT: 34 symbols moved FLASH → RAM (+7.2 KB)

Symbol	Size
`mscd_xfer_cb`	1.4 KB
`ExFatFile::write(void const*, unsigned int)`	992 B
`ExFatFile::read(void*, unsigned int)`	672 B
`FatFile::write(void const*, unsigned int)`	524 B
`FatFile::readPrivate(void, unsigned int, DirFat_t*)`	498 B
`ExFatFile::seekSet(unsigned long long)`	468 B
`ExFatFile::buildSectorMap()`	444 B
`FatFile::buildSectorMap()`	358 B
`mscd_control_xfer_cb`	328 B
`FatFile::seekSet(unsigned long)`	272 B
`FatFile::readSectorsDirect(unsigned long, unsigned char*, unsigned long)`	200 B
`ExFatFile::readSectorsDirect(unsigned long, unsigned char*, unsigned long)`	200 B
`FatPartition::fatGet(unsigned long, unsigned long*)`	154 B
`tud_descriptor_string_cb`	116 B
`mscd_open`	104 B
`ExFatPartition::fatGet(unsigned long, unsigned long*)`	96 B
`FsCache::prepare(unsigned long, unsigned char)`	84 B
`ExFatPartition::dirSeek(DirPos_t*, unsigned long)`	80 B
`FsCache::sync()`	74 B
`ExFatPartition::dirCache(DirPos_t const*, unsigned char)`	68 B
`ExFatFile::dirCache(unsigned char, unsigned char)`	60 B
`FatFile::cacheDirEntry(unsigned char)`	32 B
`FatFile::readDirCache()`	32 B
`mscd_reset`	20 B
`mscd_init`	20 B
`FsBaseFile::operator=(FsBaseFile const&)`	12 B
`tud_descriptor_configuration_cb`	8 B
`operator delete(void*, unsigned int)`	8 B
`operator new[](unsigned int)`	8 B
`tud_descriptor_device_cb`	8 B
... and 4 more

Pico_DaynaPORT: 3 symbols moved RAM → FLASH (-1.2 KB RAM)

Symbol	Size
`amigaWifiCommand`	1.2 KB
`StreamFile<FsBaseFile, unsigned long long>::peek()`	34 B
`StreamFile<FatFile, unsigned long>::peek()`	10 B

Ultra: 4 symbols moved FLASH → RAM (+16 B)

Symbol	Size
`operator new(unsigned int)`	4 B
`operator delete[](void*)`	4 B
`operator new[](unsigned int)`	4 B
`operator delete(void*, unsigned int)`	4 B

Ultra: 9 symbols moved RAM → FLASH (-298 B RAM)

Symbol	Size
`tud_descriptor_device_cb`	116 B
`tud_descriptor_string_cb`	96 B
`_lseek`	16 B
`_close`	16 B
`_fstat`	16 B
`_isatty`	16 B
`tud_descriptor_configuration_cb`	12 B
`_read`	6 B
`_write`	4 B

Ultra_Wide: 4 symbols moved FLASH → RAM (+16 B)

Symbol	Size
`operator delete(void*, unsigned int)`	4 B
`operator new[](unsigned int)`	4 B
`operator delete[](void*)`	4 B
`operator new(unsigned int)`	4 B

Ultra_Wide: 9 symbols moved RAM → FLASH (-298 B RAM)

Symbol	Size
`tud_descriptor_device_cb`	116 B
`tud_descriptor_string_cb`	96 B
`_fstat`	16 B
`_lseek`	16 B
`_close`	16 B
`_isatty`	16 B
`tud_descriptor_configuration_cb`	12 B
`_read`	6 B
`_write`	4 B

morio and others added 5 commits April 27, 2026 18:48

initiator: skip cloning non-block SCSI peripheral types

5d19165

Only clone SCSI peripheral types that may be block types and print the full name of those types. Cherry-picked from 624d74777.

initiator: extract peripheralTypeName helper for testability

863289b

erichelgeson merged commit 8d48911 into main Apr 28, 2026
1 check passed

erichelgeson deleted the eric/otherfixes branch April 28, 2026 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Other Fixes#364

Other Fixes#364
erichelgeson merged 5 commits intomainfrom
eric/otherfixes

erichelgeson commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

erichelgeson commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

BlueSCSI Memory Report

Memory Usage

Symbol Region Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants