Optimize local LLM cleanup by keeping worker process alive - #7
Open
AbarnaaSree wants to merge 2 commits into
Open
AbarnaaSree wants to merge 2 commits into
AbarnaaSree wants to merge 2 commits into
Conversation
nitrimandylis
pushed a commit
to nitrimandylis/WhimprFlow
that referenced
this pull request
Sep 12, 2026
* port windows: complete the hotkey surface and pill controls The Windows layer (cfg(target_os=windows), never compiled until now) was missing the symbols lib.rs calls via hotkey::. Add them mirroring the macOS surface: - models_dir/model_path with language-aware model selection (honours Settings.whisper_model, otherwise picks .en variants for English and multilingual ggml-*.bin otherwise) - read_openai_key/read_anthropic_key via env var or keyring - real ui_start/ui_stop/ui_cancel/trigger_hands_free wired to the hook thread's on_ptt_* handlers (no more empty stubs) - LAST_BAR + last_bar remembered in emit_bar - make rebuild_asr pub - fix the Windows re-export to match the macOS export list Verified: cargo check --target x86_64-pc-windows-gnu -j1 (in src-tauri), cargo check --workspace -j1, cargo test --workspace -j1. The Cargo.lock is synced to the 1.0.0 version bump from ed09182. * ci: add Windows build workflow (Phase 2) Windows CI modeled on build-macos.yml: builds the whimpr-llm-worker sidecar for x86_64-pc-windows-msvc, stages it into src-tauri/binaries, runs cargo check/test across the workspace, and builds the frontend so the Tauri app bundles. Runs on pull_request to gate the Windows port. * fix: guard icon_as_template (macOS-only) on non-macOS icon_as_template(true) is macOS-only in Tauri v2 and would panic at startup on Windows. Apply the template only on macOS; other platforms just set the full-color icon. Runtime fix identified in Phase 3. * fix: normalize push-to-talk key to Right Control on Windows The macOS-only PushToTalkKey concept (Fn / Globe, Right Command, Right Option) leaked into the Windows settings UI: the default is 'fn', but the Windows keyboard hook only implements Right Control (PTT_VK). The setting was ignored on Windows, so the app advertised a key that did nothing while only Right Control worked. Normalize push_to_talk_key to RightControl on load and on save so every reader (settings pane, onboarding, FlowBar, history) shows the key the hook actually responds to. Fix found during the Phase 3 Windows runtime pass (issue Blueturboguy07#7). * fix: hide macOS-only keys and copy on Windows (issue Blueturboguy07#9) * dev: add portable Windows dev launcher (dev.ps1) and README notes * docs: dual-platform run instructions (macOS + Windows) * docs: consolidate dual-platform Windows run instructions * docs: add platform differences table to README --------- Co-authored-by: skibkitty <272934292+skibkitty@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the local LLM worker lifecycle to improve performance and reduce unnecessary worker creation.
Changes
Benefits
Testing