Skip to content

配置更新启动器#138

Merged
BnanZ0 merged 4 commits into
BnanZ0:mainfrom
ok-oldking:main
May 30, 2026
Merged

配置更新启动器#138
BnanZ0 merged 4 commits into
BnanZ0:mainfrom
ok-oldking:main

Conversation

@ok-oldking
Copy link
Copy Markdown
Contributor

@ok-oldking ok-oldking commented May 30, 2026

Summary by CodeRabbit

  • Chores
    • 优化发布工作流:新增版本号格式校验,只有符合版本规则的 tag/分支才会触发相应的构建与发布步骤,提升自动化发布可靠性。
    • 新增应用更新配置:添加目标版本、更新包下载地址与 SHA256 完整性校验信息,便于后续自动化更新流程使用。

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 90d9a674-9f68-426b-8dd3-b92dcb7cb9c4

📥 Commits

Reviewing files that changed from the base of the PR and between d939c19 and fa31b87.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

📝 Walkthrough

Walkthrough

该 PR 在 GitHub Actions 中新增语义化版本格式校验并用 is_release 控制构建/发布/镜像上传步骤;同时在 src/config.py 的全局 config 中新增 update_pyappify 元数据(目标版本、zip 下载地址、sha256)。

Changes

发布流程和更新配置

Layer / File(s) Summary
Release 版本验证步骤和条件更新
.github/workflows/build.yml
新增 Check release version 步骤以正则验证 github.ref_name(支持 v1.2.31.2.3),输出 is_releaseBuild with PyAppify ActionReleaseTrigger MirrorChyanUploading 三个步骤的 if 条件更新为同时要求 is_release == 'true'(且发布/镜像步骤还要求 github.refrefs/tags/)。
更新配置数据
src/config.py
全局 config 字典新增 update_pyappify 子配置,包含 to_versionzip_urlsha256

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 版本守门轻敲锣,语义匹配不含糊,
构建发布双重锁,镜像上传亦随波,
配置添了新元件,更新包路有凭据,
小兔跳跃唱一曲,流水线上更清楚。

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive PR标题"配置更新启动器"过于宽泛模糊,未能清晰反映实际变更内容(添加release版本检查和更新配置元信息)。 建议更新标题为更具体的描述,如"添加Release版本校验和PyAppify更新配置",以更准确地反映代码变更的实质内容。
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build.yml:
- Around line 82-84: The pwsh step currently directly interpolates GitHub
expression into a PowerShell string via $tag = "${{ github.ref_name }}", which
can break the script or allow injection; change the step to pass the ref name
via the step's env (e.g. set REF_NAME: ${{ github.ref_name }}) and in the script
read it with $tag = $env:REF_NAME (or use $env:REF_NAME.Trim()) and then use
that $tag in the regex check ($isRelease = $tag -match '...') and output; update
occurrences of $tag and the is_release output code to use the env-derived value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 32eaeea6-97f7-4702-88ca-0c31e51148cb

📥 Commits

Reviewing files that changed from the base of the PR and between b5445bd and d939c19.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • src/config.py

Comment thread .github/workflows/build.yml Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@BnanZ0 BnanZ0 merged commit 87c67ae into BnanZ0:main May 30, 2026
1 of 2 checks passed
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants