Repository navigation
Pin gpui-mobile with the night-mode and emoji review fixes - #22
Merged
Merged
Conversation
Fork main 3d74121 merges the revised android-host-night-mode (c62c318) and android-host-emoji-font (77126f2), which longbridge/gpui-mobile#30 and #29 will carry: night mode is read from the application context, and the emoji font's AssetManager is kept for the life of the process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins fork
main3d74121, which merges the revisedandroid-host-night-mode(c62c318) andandroid-host-emoji-font(77126f2). Those are what longbridge/gpui-mobile#30 and #29 will carry after the adversarial review:configuration_changed()now syncs every host's window.unsafe impl Send. It is lent out through a crate-privatewith_asset_manager, replacing the publicasset_manager()that could return a dangling pointer. A failed JNI call no longer leaves an exception pending.This APK is for re-testing both on the phone before force-pushing the upstream branches.
🤖 Generated with Claude Code