Skip to content

Docs: describe the revised night-mode (#30) and emoji (#29) patches #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bombatomica64 merged 1 commit into from
Oct 9, 2026
Merged

Docs: describe the revised night-mode (#30) and emoji (#29) patches #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions MOBILE_PATCHES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,25 @@ in a dialog closed the dialog. Done now hides the keyboard and keeps focus,
like back. `show_soft_keyboard` / `hide_soft_keyboard` are implemented, so
`Window::request_virtual_keyboard` works (Kit's Input uses it below).

### Give the host-driven path the Activity's AssetManager — branch `android-host-appearance-emoji`

Without `android-activity` there was no AssetManager, so the window never
followed night mode (and `Platform::window_appearance` always said Dark),
and the bundled CBDT emoji font could not be read (Android 13+'s COLRv1
emoji font cannot be drawn by swash). `set_host_activity` now keeps the
Activity's AssetManager; the host path syncs each window's night mode when
it opens, re-attaches and resumes, and through the new
`host::configuration_changed()` for Activities that handle `uiMode`
themselves.

For upstream, this is split into two branches off upstream `main`, which
together equal the commit above: `android-host-night-mode` (night mode,
`window_appearance`, `configuration_changed()`;
[#30](https://github.com/longbridge/gpui-mobile/pull/30)) and
`android-host-emoji-font` (the AssetManager and the emoji font;
[#29](https://github.com/longbridge/gpui-mobile/pull/29)).
### Follow the system night mode on the host path — branch `android-host-night-mode`, [#30](https://github.com/longbridge/gpui-mobile/pull/30)

Without `android-activity`, night mode was never read, so the window stayed
Light (and `Platform::window_appearance` always said Dark). It is now read
from the application context's configuration, which the first
`set_host_activity` keeps, and applied to each window when it opens,
re-attaches and resumes. An Activity that handles `uiMode` itself must call
the new `host::configuration_changed()`, which updates every host's window.

### Load the bundled emoji font on the host path — branch `android-host-emoji-font`, [#29](https://github.com/longbridge/gpui-mobile/pull/29)

Android 13+'s COLRv1 emoji font cannot be drawn by swash, and the bundled
CBDT fallback was only read through `android-activity`'s AssetManager, so
emoji were empty boxes. The first `set_host_activity` keeps the
application's AssetManager for the life of the process.

Both were one branch, `android-host-appearance-emoji`, until an adversarial
review: night mode came from whichever Activity registered last, and the
public `asset_manager()` could return a dangling pointer.

## GPUI Kit

Expand Down
Loading