Repository navigation
gpui-mobile: pin the #29 review follow-up, draft the reply - #65
Conversation
Pins Bombatomica64/gpui-mobile main at 2456b8e (fork PR #11), which merges the review fixes for longbridge/gpui-mobile#29. The reply to the review is drafted in docs/upstream/replies/gpui-mobile-29.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb60a2e891
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gpui = { package = "gpui-pre", version = "=0.3.8", default-features = false } | ||
| gpui-kit = { git = "https://github.com/Bombatomica64/gpui-kit", rev = "d47dd0bde03345977db286f9bc8224bf1199cb60", default-features = false, features = ["component", "assets"] } | ||
| gpui-mobile = { package = "gpui-pre-mobile", git = "https://github.com/Bombatomica64/gpui-mobile", rev = "dc07d18a7e5590293b4f0759b4b7e290cca5f3c2", default-features = false, features = [ | ||
| gpui-mobile = { package = "gpui-pre-mobile", git = "https://github.com/Bombatomica64/gpui-mobile", rev = "2456b8e91ca98f37cea00c8e6a1a3e1b0f8a2410", default-features = false, features = [ |
There was a problem hiding this comment.
After this dependency is pinned to 2456b8e, GPUI_MOBILE_REVISION in src/lib.rs still names dc07d18; consequently, both the app summary and Diagnostics screen report that newly built APKs use the previous dependency revision. Update that constant alongside this pin so diagnostic reports retain accurate build provenance.
Useful? React with 👍 / 👎.
1 participant
Bombatomica64/gpui-mobilemainat2456b8e(fork PR Emoji font: review follow-up from longbridge/gpui-mobile#29 gpui-mobile#11), which merges the review fixes for android: Load the bundled emoji font on the host-driven path longbridge/gpui-mobile#29: deferred emoji-font load whenhost::startcomes first, JNI local frame inhost_assets, exceptions cleared on everyset_host_activityerror path, single-buffer asset read.docs/upstream/replies/gpui-mobile-29.md(to be posted by hand).MOBILE_PATCHES.mdnotes the deferred load.cargo check --target aarch64-linux-androidpasses locally; APK via CI. Phone check of emoji rendering: pending.🤖 Generated with Claude Code