Repository navigation
Address the #25 review: per-host TalkBack Activity, reply draft - #69
Conversation
Pin gpui-mobile main 4acd176 (android-accessibility rebased onto upstream main plus one commit per review point). LabActivity passes its host id to nativeOnCreate, which now calls host::set_activity, so TalkBack lands on the right Activity after Back. Adds the reply draft for longbridge/ gpui-mobile#25 and updates MOBILE_PATCHES.md, the upstream table and the skill's host wiring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04018ba50f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gpui = { package = "gpui-pre", version = "=0.3.8", default-features = false } | ||
| gpui-kit = { git = "https://github.com/Bombatomica64/gpui-kit", rev = "e8b28164ac7fa7e1f7d393d441beb738c286bbc8", default-features = false, features = ["component", "assets"] } | ||
| gpui-mobile = { package = "gpui-pre-mobile", git = "https://github.com/Bombatomica64/gpui-mobile", rev = "c71a31aaa12660552ca7a772f6fdd890d9c8cf7a", default-features = false, features = [ | ||
| gpui-mobile = { package = "gpui-pre-mobile", git = "https://github.com/Bombatomica64/gpui-mobile", rev = "4acd1761b4b2a734f49ff2bce930c61b01cfe5be", default-features = false, features = [ |
There was a problem hiding this comment.
Updating this dependency pin to 4acd176 without changing GPUI_MOBILE_REVISION in src/lib.rs makes both the Diagnostics screen and app metadata continue reporting c71a31a. Any APK built from this commit therefore misidentifies the gpui-mobile code under test, which is especially misleading when validating the newly pinned accessibility fixes; update the constant alongside the pin.
Useful? React with 👍 / 👎.
1 participant
Addresses huacnlee's review of longbridge/gpui-mobile#25 on the fork, and drafts the reply.
main4acd176:android-accessibilityrebased onto upstreammain(conflicted with Epic: native views, navigation and gestures (React Native parity) #29) plus one commit per review point; theandroid-a11y-clear-exceptionscommit is folded in.LabActivitypasses its host id tonativeOnCreate, which calls the newhost::set_activityso TalkBack follows each host's own Activity (review point 1).docs/upstream/replies/gpui-mobile-25.md. Not posted.Point 2 (the
isEnabled()race) can only be partly fixed in gpui-mobile; the draft explains why and asks how to proceed.Checked:
cargo check --target aarch64-linux-android(lab, no warnings). Device checks pending: the phone tunnel was down.🤖 Generated with Claude Code