Skip to content

Docs: the hot-reload question is posted as longbridge/gpui-mobile#34 - #73

Merged
Bombatomica64 merged 1 commit into
mainfrom
hot-reload-issue-posted
Oct 12, 2026
Merged

Bombatomica64 merged 1 commit into
mainfrom
hot-reload-issue-posted

Conversation

@Bombatomica64

Copy link
Copy Markdown
Owner

Marks the draft from #71 as posted (longbridge/gpui-mobile#34) in the draft itself, in docs/upstream/README.md (row 20), in MOBILE_PATCHES and in CONTRIBUTING_IDEAS item 4. Docs only.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T14:58:10.349358Z 7a2fbb1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a2fbb1713

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CONTRIBUTING_IDEAS.md
loader for the pushed library (`GpuiLibraryLoader`, fork branch
`dev-hot-loader`). Next: ask upstream where they want it
([issue draft](docs/upstream/hot-reload-discussion.md)). A desktop-hosted
([longbridge/gpui-mobile#34](https://github.com/longbridge/gpui-mobile/issues/34)). A desktop-hosted

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark the upstream question as completed

When contributors follow this ordered work list, the entry still says the next action is to ask upstream where the loader should live, even though the newly linked issue and updated discussion document say that question was already posted. This leaves the planning status stale and can prompt someone to repeat completed work; change the text to record that upstream was asked and identify the actual next step, such as waiting for a response.

Useful? React with 👍 / 👎.

@Bombatomica64
Bombatomica64 merged commit ed1f382 into main Oct 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant