Repository navigation
Move to gpui-pre 0.3.9, GPUI Kit 0.7.3 and gpui-mobile main - #78
Merged
Merged
Conversation
gpui-mobile merged #25 (TalkBack), #29 (emoji) and #30 (night mode), and moved to gpui-pre 0.3.9 with Kit 0.7.3. The three forks are rebased onto those (old tips kept as archive/* tags), and gpui-hot accepts any 0.3 snapshot (cargo-gpui #3). Kit's mobile-lab also gains a fix that keeps sheets and toasts out from under the system bars and the keyboard. Docs: the merged PRs, the PRs opened today (gpui-kit #3554-#3557, gpui-mobile #39-#41) and the new bases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpui-mobile merged #25 (TalkBack), #29 (emoji) and #30 (night mode) and moved to gpui-pre 0.3.9; GPUI Kit 0.7.3 is on 0.3.9 too. This moves the lab to all three.
Pins
=0.3.9, patched with the fork'smobile-lab5df735c(0.3.9 + touch-drag, autoscroll, touch-axis,purpose).mobile-lab4ff4754(v0.7.3 + 10 commits). The long-press context menu dropped out because v0.7.3 has it. New: sheets and toasts are inset byWindow::fully_visible_bounds(), so they stay out from under the system bars and the keyboard (Kit UI test included; upstream PR after phone captures).main7f52b45(upstreammainmerged; fast-forward).>=0.3.8, <0.4).archive/pre-0.3.9/main,archive/v0.7.1/mobile-labandarchive/0.3.8/*.Docs: MOBILE_PATCHES.md, CONTRIBUTING_IDEAS.md, docs/upstream/README.md and the README list the merged PRs and the ones opened today (gpui-kit #3554–#3557, gpui-mobile #39–#41).
Checked:
cargo ndk -t arm64-v8a checkwith no warnings. Not yet: a phone run — needed before merging (night mode, emoji, TalkBack, the insets and the new sheet insets).🤖 Generated with Claude Code