Add AWS Secrets Manager/KMS node key support - #129
Merged
Conversation
Add support for loading P2P node keys from AWS Secrets Manager with optional AWS KMS decryption.
Update repository to use Go 1.25.8
purplesmoke05
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for securely managing P2P node keys using AWS Secrets Manager and optional AWS KMS decryption, allowing node keys to be fetched and decrypted at runtime rather than stored directly on disk. The changes include new CLI flags, TOML configuration options, and the implementation of fetcher and decrypter logic for AWS-based node key management. Documentation and tests are also added to ensure correct usage and behavior.
AWS Node Key Management Integration
NodeKeyAwsSecretsManagerFetcher) and decrypter (NodeKeyAwsKmsDecrypter) implementations. [1] [2]Managerclass to coordinate node key retrieval and decryption based on CLI and TOML configuration, supporting both plaintext and encrypted flows.AwsClientutility for initializing AWS SDK clients and validating configuration.CLI and Configuration Enhancements
--nodekeysourceand--nodekeydecryptionto select node key source and decryption scheme, defaulting to file/plaintext but supporting AWS flows. [1] [2]setNodeKeylogic inflags.goto handle new source/decryption flows, with legacy flags taking precedence.Documentation
docs/aws-nodekey.mdand updatedREADME.mdto describe AWS node key management, CLI options, configuration, and IAM requirements.