Refactor lock and transfer data models to remove deprecated inheritance message - #1660
Merged
Conversation
purplesmoke05
marked this pull request as ready for review
July 24, 2025 00:19
YoshihitoAso
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
This pull request introduces new data models for lock and unlock messages, refactors existing code to use these models, and updates database migration and test cases accordingly. The changes aim to improve data validation and consistency across the system.
✅ Related Issues
🔄 Changes
Lock/Unlock Message Standardization
LockDataMessageandUnlockDataMessageclasses inapp/model/db/idx_lock_unlock.pyto define structured data models for lock and unlock messages usingpydanticandStrEnum. [1] [2] [3]IDXLockandIDXUnlockmodels to explicitly document that thedatafield usesLockDataMessageandUnlockDataMessage. [1] [2]Data Validation
model_validatein batch processing scripts (indexer_Position_Bond.pyandindexer_Position_Share.py). [1] [2] [3] [4]Migration Script
migrations/versions/819325835c3d_v25_9_0_feature_1657.py) to clean up legacy data by removing references to the deprecated "inheritance" message type fromIDXTransfer,IDXLock, andIDXUnlock.📌 Checklist