Add notification category to Notification model and implement attribute change tracking watcher

[purplesmoke05]

📌 Description

This pull request introduces a new notification_category field to classify notifications by type, along with updates to the database schema, API, and batch processors to support this functionality. Additionally, it implements a Watcher to monitor changes to the transferable attribute of contracts.

✅ Related Issues

• Close [FEATURE] Add notification triggers for contract attribute changes #1662

🔄 Changes

Database Schema Enhancements:

• Added a new notification_category field to the Notification model to classify notifications as either "event_log" or "attribute_change" (app/model/db/notification.py).
• Introduced the NotificationAttributeValue model to store synchronized attribute values for notifications (app/model/db/notification.py).
• Updated the NotificationType enum to include new types for attribute change notifications (app/model/db/notification.py) [1] [2].

API Updates:

• Added notification_category as a query parameter in the list_all_notifications API to enable filtering by category (app/api/routers/notification.py) [1] [2].
• Updated the NotificationsQuery and Notification schemas to include the notification_category field (app/model/schema/notification.py) [1] [2].

Batch Processor Modifications:

• Updated batch processors (processor_Notifications_Coupon_Exchange.py, processor_Notifications_Membership_Exchange.py, processor_Notifications_Token.py) to set the notification_category field to "event_log" when creating notifications [1] [2] [3].

Codebase Simplifications:

• Renamed Watcher to EventWatcher in processor_Notifications_Token.py for clarity and consistency (batch/processor_Notifications_Token.py).
• Improved imports by grouping related modules and adding missing dependencies (batch/processor_Notifications_Token.py) [1] [2].

📌 Checklist

• I have added tests where necessary.
• I have updated the documentation where necessary.

[github-actions]

Coverage Report •

File	Stmts	Miss	Cover	Missing
app/api/routers
notification.py	87	0	100%
app/model/db
__init__.py	20	0	100%
notification.py	71	3	95%	50, 127, 136
app/model/schema
notification.py	64	0	100%
batch
processor_Notifications_Coupon_Exchange.py	305	34	88%	101, 121–122, 127, 138, 155, 157, 183, 224, 265, 309, 350, 391, 432, 476, 517, 561, 588, 600, 602–603, 605–606, 609–611, 613–614, 616–617, 621–624
processor_Notifications_Membership_Exchange.py	305	34	88%	101, 121–122, 127, 138, 155, 157, 183, 224, 268, 312, 353, 394, 438, 482, 526, 570, 597, 609, 611–612, 614–615, 618–620, 622–623, 625–626, 630–633
processor_Notifications_Token.py	381	37	90%	142, 176, 198, 200, 225–228, 357, 403, 449, 660, 707, 733, 742–743, 747–748, 797–798, 909, 921, 923–924, 926–927, 930–932, 934–935, 937–938, 942–945
tests/app
notification_NotificationsCount_test.py	100	0	100%
notification_NotificationsId_DELETE_test.py	104	0	100%
notification_NotificationsId_POST_test.py	128	0	100%
notification_NotificationsRead_test.py	125	0	100%
notification_Notifications_GET_test.py	138	0	100%
tests/batch
processor_Notifications_Coupon_Exchange_test.py	748	0	100%
processor_Notifications_Membership_Exchange_test.py	748	0	100%
processor_Notifications_Token_test.py	1263	1	99%	71
TOTAL	45115	1576	96%

Tests	Skipped	Failures	Errors	Time
1502	0 💤	0 ❌	0 🔥	13m 5s ⏱️

[Copilot]

Pull Request Overview

This pull request introduces a new notification_category field to classify notifications by type ("event_log" or "attribute_change"), along with implementing a Watcher to monitor changes to the transferable attribute of contracts. It includes comprehensive database schema updates, API enhancements, and batch processor modifications to support this functionality.

• Added notification categorization system to differentiate between event-based and attribute-change notifications
• Implemented new WatchTransferableAttribute watcher to track changes in token transferability
• Updated all existing notification creation points to set appropriate category values

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
migrations/versions/a5e395bf46a9_v25_9_0_feature_1662.py	Database migration adding notification_category field and NotificationAttributeValue table
app/model/db/notification.py	Added notification_category field, NotificationAttributeValue model, and new notification types
app/model/schema/notification.py	Updated API schemas to include notification_category field
app/api/routers/notification.py	Added notification_category query parameter to notifications API
batch/processor_Notifications_Token.py	Renamed Watcher to EventWatcher, added WatchTransferableAttribute class, updated all notification creation to include category
batch/processor_Notifications_Coupon_Exchange.py	Updated notification creation to set notification_category = "event_log"
batch/processor_Notifications_Membership_Exchange.py	Updated notification creation to set notification_category = "event_log"
tests/*	Updated all test files to include notification_category assertions and test data
docs/ibet_wallet_api.yaml	Updated API documentation to include notification_category field

Comments suppressed due to low confidence (2)

tests/batch/processor_Notifications_Token_test.py:2332

• The lock_account variable is removed but was not used in the original code. This removal is correct but consider verifying that this variable wasn't referenced elsewhere in the codebase.

    issuer = eth_account["issuer"]

tests/batch/processor_Notifications_Token_test.py:2729

• Similar to the previous instance, the lock_account variable is removed. Ensure this variable wasn't referenced in other parts of the test class.

    issuer = eth_account["issuer"]