Skip to content

Fix balance indexing - #1664

Merged
YoshihitoAso merged 2 commits into
dev-25.9from
fix-balance-indexing
Jul 31, 2025
Merged

Fix balance indexing#1664
YoshihitoAso merged 2 commits into
dev-25.9from
fix-balance-indexing

Conversation

@YoshihitoAso

@YoshihitoAso YoshihitoAso commented Jul 31, 2025

Copy link
Copy Markdown
Member

📌 Description

Fix #1652
Fix #1661

✅ Related Issues

🔄 Changes

Position Handling Simplifications:

  • Simplified the condition in __sink_on_position methods across multiple files (batch/indexer_Position_Bond.py, batch/indexer_Position_Coupon.py, batch/indexer_Position_Membership.py, batch/indexer_Position_Share.py) by removing the value > 0 check, leaving only value is not None. [1] [2] [3] [4]

API Documentation Updates:

  • Added two new notification types, ChangeToRedeemed and ChangeToCanceled, to the NotificationType component in docs/ibet_wallet_api.yaml.

📌 Checklist

  • I have added tests where necessary.
  • I have updated the documentation where necessary.

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
batch
   indexer_Position_Bond.py90611986%92–95, 253, 450–451, 469–470, 533–534, 552–553, 617–618, 636–637, 702–703, 721–722, 807–808, 827–828, 865–866, 903–904, 941–942, 979–980, 1017–1018, 1030, 1044–1045, 1069–1070, 1077, 1094–1095, 1102, 1119–1120, 1144–1145, 1147–1148, 1151–1153, 1163, 1179–1180, 1238–1239, 1251, 1265–1266, 1273, 1288–1289, 1291–1292, 1295–1297, 1311–1312, 1319, 1372–1373, 1385, 1399–1400, 1407, 1422–1423, 1425–1426, 1429–1431, 1445–1446, 1453, 1468–1469, 1476, 1529–1530, 1639–1640, 1669–1670, 1723–1724, 1804–1805, 1955, 1960–1961, 1973–1974, 1989–1990, 2002–2003, 2012–2015, 2018, 2022–2025
   indexer_Position_Coupon.py4899281%78–81, 239, 370–376, 379–382, 385, 389–391, 397–398, 410, 424–425, 449–450, 457, 474–475, 482, 499–500, 524–525, 527–528, 531–533, 543, 559–560, 618–619, 631, 643–644, 651, 666–667, 669–670, 673–675, 689–690, 697, 754–755, 853–854, 865, 871, 907–908, 940, 999, 1004–1005, 1008, 1011–1012, 1014–1018, 1033–1034, 1046–1047, 1056–1059, 1062, 1066–1069
   indexer_Position_Membership.py4717584%78–81, 239, 373, 387–388, 412–413, 420, 437–438, 445, 462–463, 487–488, 490–491, 494–496, 506, 522–523, 581–582, 594, 606–607, 614, 629–630, 632–633, 636–638, 652–653, 660, 717–718, 817–818, 829, 835, 871–872, 904, 963, 968–969, 972, 975–976, 978–982, 997–998, 1010–1011, 1020–1023, 1026, 1030–1033
   indexer_Position_Share.py90611787%94–95, 253, 450–451, 469–470, 533–534, 552–553, 617–618, 636–637, 702–703, 721–722, 807–808, 827–828, 865–866, 903–904, 941–942, 979–980, 1017–1018, 1030, 1044–1045, 1069–1070, 1077, 1094–1095, 1102, 1119–1120, 1144–1145, 1147–1148, 1151–1153, 1163, 1179–1180, 1238–1239, 1251, 1265–1266, 1273, 1288–1289, 1291–1292, 1295–1297, 1311–1312, 1319, 1372–1373, 1385, 1399–1400, 1407, 1422–1423, 1425–1426, 1429–1431, 1445–1446, 1453, 1468–1469, 1476, 1529–1530, 1639–1640, 1669–1670, 1723–1724, 1804–1805, 1955, 1960–1961, 1973–1974, 1989–1990, 2002–2003, 2012–2015, 2018, 2022–2025
tests/batch
   indexer_Position_Bond_test.py9800100% 
   indexer_Position_Coupon_test.py4750100% 
   indexer_Position_Membership_test.py4470100% 
   indexer_Position_Share_test.py9770100% 
TOTAL44735157296% 

Tests Skipped Failures Errors Time
1497 0 💤 0 ❌ 0 🔥 13m 35s ⏱️

@YoshihitoAso
YoshihitoAso merged commit e0f9f42 into dev-25.9 Jul 31, 2025
12 checks passed
@YoshihitoAso
YoshihitoAso deleted the fix-balance-indexing branch July 31, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants