Skip to content

refactor: Tidy up test helpers - #1759

Merged
YoshihitoAso merged 2 commits into
dev-26.3from
tidy-up-test-helpers
Feb 13, 2026
Merged

refactor: Tidy up test helpers#1759
YoshihitoAso merged 2 commits into
dev-26.3from
tidy-up-test-helpers

Conversation

@YoshihitoAso

@YoshihitoAso YoshihitoAso commented Feb 11, 2026

Copy link
Copy Markdown
Member

📌 Description

This pull request refactors the test helpers.
It replaces contract deployment and transaction helpers with the new IbetXXXTestHelper, streamlining test code and improving clarity.

✅ Related Issues

None

🔄 Changes

  • Separate test helpers by purpose.
  • Consolidate all operations on the contract into helpers.

📌 Checklist

  • I have added tests where necessary.
  • I have updated the documentation where necessary.

@YoshihitoAso
YoshihitoAso marked this pull request as ready for review February 11, 2026 14:55
@github-actions

github-actions Bot commented Feb 11, 2026

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
tests
   conftest.py1761492%220, 232–236, 239, 271, 281–286
tests/app
   admin_Tokens_POST_test.py2430100% 
   company_info_ListAllCompanies_test.py4000100% 
   company_info_ListAllCompanyTokens_test.py1910100% 
   e2e_message_EncryptionKey_test.py370100% 
   eth_SendRawTransactionNowait_test.py2800100% 
   eth_SendRawTransaction_test.py4500100% 
   eth_WaitForTransactionReceipt_test.py880100% 
   events_E2EMessagingEvents_test.py1670100% 
   events_IbetEscrowEvents_test.py1880100% 
   events_IbetSecurityTokenDVPEvents_test.py2550100% 
   events_IbetSecurityTokenEscrowEvents_test.py3120100% 
   events_IbetSecurityTokenInterfaceEvents_test.py242498%130, 147–148, 152
   position_PositionCouponContractAddress_test.py3740100% 
   position_PositionCoupon_test.py406299%188, 195
   position_PositionMembershipContractAddress_test.py1660100% 
   position_PositionMembership_test.py283299%146, 153
   position_PositionShareContractAddress_test.py636299%202, 211
   position_PositionShare_test.py359299%208, 217
   position_PositionStraightBondContractAddress_test.py419399%198, 205, 207
   position_PositionStraightBond_test.py336399%200, 207, 209
   token_TokenHoldersCollectionId_test.py1150100% 
   token_TokenHoldersCollection_test.py1770100% 
   token_TokenStatus_test.py1210100% 
   token_bond_StraightBondTokenAddresses_test.py3390100% 
   token_bond_StraightBondTokenDetails_test.py1150100% 
   token_bond_StraightBondTokens_test.py3850100% 
   token_coupon_CouponTokenAddresses_test.py3260100% 
   token_coupon_CouponTokenDetails_test.py1060100% 
   token_coupon_CouponTokens_test.py3710100% 
   token_membership_MembershipTokenAddresses_test.py3260100% 
   token_membership_MembershipTokenDetails_test.py1070100% 
   token_membership_MembershipTokens_test.py3720100% 
   token_share_ShareTokenAddresses_test.py3340100% 
   token_share_ShareTokenDetails_test.py1100100% 
   token_share_ShareTokens_test.py3810100% 
   userinfo_PersonalInfo_test.py670100% 
tests/batch
   indexer_Consume_Coupon_test.py2630100% 
   indexer_Position_Bond_test.py9350100% 
   indexer_Position_Coupon_test.py4240100% 
   indexer_Position_Membership_test.py3970100% 
   indexer_Position_Share_test.py9160100% 
   indexer_Token_Detail_ShortTerm_test.py3410100% 
   indexer_Token_Detail_test.py1990100% 
   indexer_Token_Holders_test.py366498%206, 219–220, 225
   indexer_Token_List_Event_test.py3040100% 
   indexer_TransferApproval_test.py4260100% 
   indexer_Transfer_test.py6090100% 
   processor_Notifications_Token_test.py1293299%53, 55
tests/helpers
   __init__.py70100% 
   contract.py54885%120, 122–126, 128, 130
   e2e_messaging.py130100% 
   ibet_bond_token.py125794%461, 467, 470, 478, 492, 495, 498
   ibet_coupon_token.py310100% 
   ibet_exchange_helpers.py670100% 
   ibet_membership_token.py260100% 
   ibet_share_token.py140199%224
   ibet_standard_token.py160100% 
   personal_info.py80100% 
TOTAL37331132896% 

Tests Skipped Failures Errors Time
1270 0 💤 0 ❌ 0 🔥 9m 56s ⏱️

@YoshihitoAso
YoshihitoAso marked this pull request as draft February 11, 2026 23:43
@YoshihitoAso
YoshihitoAso marked this pull request as ready for review February 12, 2026 06:41
@YoshihitoAso
YoshihitoAso merged commit c3e6a24 into dev-26.3 Feb 13, 2026
12 checks passed
@YoshihitoAso
YoshihitoAso deleted the tidy-up-test-helpers branch February 13, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants