Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the UniverSheet component’s XML documentation to better describe the OnPostDataAsync callback, clarifying that it is a UniverSheet data callback typically triggered by an Excel button. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
Updates the UniverSheet component’s XML documentation to better describe the OnPostDataAsync callback, as part of the documentation refresh requested in #943.
Changes:
- Reworded the bilingual
<summary>forOnPostDataAsyncto describe its purpose/trigger.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// <para lang="zh">获得/设置 UniverSheet 数据回调方法(一般由 Excel 按钮触发)</para> | ||
| /// <para lang="en">Gets or sets the UniverSheet data callback method (usually triggered by the Excel button).</para> |
There was a problem hiding this comment.
The updated summary mentions the callback is usually triggered by an “Excel button”, but there’s no corresponding concept in the component/JS (TriggerPostData is invoked via JS interop from wwwroot/data-service.js:getDataAsync). This makes the API documentation misleading for consumers; consider rewording to describe the actual trigger (i.e., invoked when JavaScript calls TriggerPostData / when the sheet requests data from .NET) rather than a specific UI element.
| /// <para lang="zh">获得/设置 UniverSheet 数据回调方法(一般由 Excel 按钮触发)</para> | |
| /// <para lang="en">Gets or sets the UniverSheet data callback method (usually triggered by the Excel button).</para> | |
| /// <para lang="zh">获得/设置 UniverSheet 数据回调方法(由前端通过 JavaScript 调用 TriggerPostData 或工作表向 .NET 请求数据时触发)</para> | |
| /// <para lang="en">Gets or sets the UniverSheet data callback method (invoked when JavaScript calls TriggerPostData, i.e., when the sheet requests data from .NET).</para> |
Link issues
fixes #943
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Documentation: