Skip to content

bug(DockView): fix title incorrect when switch lang #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 3 commits into from
Mar 18, 2026
+4 −4
Merged

bug(DockView): fix title incorrect when switch lang #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99ed7df
fix(dockview): 修复切换语言后恢复删除的panel时标题不对
zhaijunlei955 Mar 18, 2026
b257a6c
fix(dockview): 修复切换语言后恢复删除的panel多语言显示不对
zhaijunlei955 Mar 18, 2026
9e049de
chore: bump version 10.0.4-beta01
ArgoZhang Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/BootstrapBlazor.DockView/BootstrapBlazor.DockView.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>10.0.3</Version>
<Version>10.0.4-beta01</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/components/BootstrapBlazor.DockView/wwwroot/js/dockview-group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ const onAddGroup = group => {
dockview._inited && observeGroup(group)
}

const addGroupWithPanel = (dockview, panel, panels, index) => {
const addGroupWithPanel = (dockview, panel, localPanel, panels, index) => {
if (panel.groupId) {
addPanelWidthGroupId(dockview, panel, index)
}
else {
addPanelWidthCreatGroup(dockview, panel, panels)
}
deletePanel(dockview, panel)
deletePanel(dockview, localPanel)
Comment on lines +29 to +36
Copy link

@sourcery-ai sourcery-ai bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Guard against localPanel being undefined before calling deletePanel.

With the new signature, localPanel may be undefined when panels.find(...) in the caller fails, leading to deletePanel(dockview, undefined). Please either guard before calling (e.g. if (localPanel) deletePanel(...)) or ensure the caller always provides a valid panel reference.

}

const addPanelWidthGroupId = (dockview, panel, index) => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/BootstrapBlazor.DockView/wwwroot/js/dockview-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ const toggleComponent = (dockview, options) => {
let indexOfOptions = groupPanels.findIndex(p => p.params.key == panel?.params.key)
indexOfOptions = indexOfOptions == -1 ? 0 : indexOfOptions
const index = panel && panel.params.index
addGroupWithPanel(dockview, panel || p, panels, index ?? indexOfOptions);
addGroupWithPanel(dockview, p || panel, panel, panels, index ?? indexOfOptions);
}
})

Expand Down
Loading