feat(backend): env validation with Joi + submissions module#50
Open
middalukawunti-lang wants to merge 1 commit into
Open
Conversation
- Issue BountyOnChain#12: add ConfigModule.forRoot with Joi schema validating DATABASE_URL, JWT_SECRET, STELLAR_NETWORK (testnet|mainnet), PORT (default 4000); app fails fast on missing vars; update .env.example - Issue BountyOnChain#9: scaffold submissions module POST /bounties/:id/submissions — create (JWT required) GET /bounties/:id/submissions — list (owner only, JWT) PATCH /bounties/:id/submissions/:s/approve — approve + Soroban release call PATCH /bounties/:id/submissions/:s/reject — reject (owner only, JWT) Enforces one approval per bounty. Closes BountyOnChain#9, Closes BountyOnChain#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves both issues assigned to @middalukawunti-lang.
Issue #12 — chore(backend): add environment validation with Joi
@nestjs/configandjoiConfigModule.forRootwith a Joi schema validating:DATABASE_URL(required)JWT_SECRET(required)STELLAR_NETWORK— must betestnetormainnet(required)PORT— defaults to4000TypeOrmModulemigrated toforRootAsyncso it reads fromConfigService.env.exampleupdated with all required keys and descriptionsCloses #12
Issue #9 — feat(backend): scaffold submissions module
New module at
src/submissions/with full CRUD + approval flow:/bounties/:id/submissions/bounties/:id/submissions/bounties/:id/submissions/:subId/approvereleasecall/bounties/:id/submissions/:subId/rejectCOMPLETEDreleaseis called via@stellar/stellar-sdkon approval (skipped gracefully ifSOROBAN_CONTRACT_IDis not set)notescolumn toSubmissionentityCloses #9