Plugins #21
Merged
Plugins #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QTTUBE_EXTERNAL_OPENSSL CMake option has also been removed.
Very basic rn and looks pretty crappy. Will be better.
Subject to change. Not sure I like how it is rn, but might end up being how it is anyway.
SQL drivers other than SQLite are excluded to reduce file size and, in the case of Mimer, fix some problems caused by their presence.
BowDown097
force-pushed
the
plugins
branch
6 times, most recently
from
0e5810f to
fa938de
Compare
Errors are also now reported in BrowseHelper if there is no active plugin and are also now reported exclusively as a text item in the respective list widget, rather than a mix of that and message boxes.
BowDown097
force-pushed
the
plugins
branch
2 times, most recently
from
5abdfb3 to
f008447
Compare
On self-contained builds, plugins are able to be installed from the plugin browser. This functionality is now disabled on non-self-contained builds. On portable builds, plugins and settings will be stored in the application directory. The functionality of self-contained builds is also inherited.
Some other minor changes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full migration of the program to a plugin system, à la Grayjay, as well as several miscellaneous changes around the program, mostly to accommodate the new system.
Current status
Creation of and migration to the plugin system is complete. All that remains is some finishing touches and bug fixes.
Status at launch
YouTube will be the only plugin, with more soon to come. May still be a little rough around the edges, but things will be more fleshed out and refined as time goes on.
These YouTube features will no longer be available, and may or may not return:
Usage
Currently, only one plugin can be active at a time. Plugins can be selected and configured from the new "Plugins" menu in the settings window. The ability to have multiple active plugins and a simple plugin dropdown in the top bar are being considered, but will likely not be there at launch.